-
-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DimensionalData extension #3413
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3413 +/- ##
==========================================
- Coverage 98.00% 97.98% -0.02%
==========================================
Files 34 36 +2
Lines 5003 4966 -37
==========================================
- Hits 4903 4866 -37
Misses 100 100
☔ View full report in Codecov by Sentry. |
So this PR now has tests and documentation. It seems reasonable to merge, but it's worth a discussion on the long-term maintenance cost vs the additional features that are offered. |
Discussed breaking changes in DimensionalData here: rafaqz/DimensionalData.jl#491. None are immediately planned, but there might be a couple before v1.0. Any changes are very unlikely to impact the code in JuMP, so consensus from the monthly call seemed to be that we should move forward with this case, and re-evaluate other extensions on a case-by-case basis. I am interested to see how the Pkg extensions go more generally, and whether they lead to questions on the forum. |
Co-authored-by: Oscar Dowson <[email protected]>
Discussed and approved during the hackathon. |
This PR is a replacement for #3383. I've added a new branch to the
jump-dev
remote so that we can generate documentation previews.https://jump.dev/JuMP.jl/previews/PR3413/extensions/DimensionalData/
I'm going to mark this as closing #3214. I don't think we need to implement methods for DenseAxisArray, we just need to make it easier to integrate with other array packages.
Closes #3214