Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump compat of DimensionalData #3666

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Bump compat of DimensionalData #3666

merged 1 commit into from
Feb 5, 2024

Conversation

odow
Copy link
Member

@odow odow commented Feb 5, 2024

So it actually took all of 2 months after merging #3413 (comment) for a breaking release to happen.

x-ref https://discourse.julialang.org/t/jump-dimensionaldata-compatibility/109736

cc @Ethan-Russell

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e4d2d7f) 98.29% compared to head (4cffba6) 98.29%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3666   +/-   ##
=======================================
  Coverage   98.29%   98.29%           
=======================================
  Files          43       43           
  Lines        5676     5676           
=======================================
  Hits         5579     5579           
  Misses         97       97           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odow odow merged commit 07eb695 into master Feb 5, 2024
12 checks passed
@odow odow deleted the od/dimensionaldata branch February 5, 2024 20:58
@mlubin
Copy link
Member

mlubin commented Feb 5, 2024

Would a compat helper script that notifies us of new releases of dependencies work here?

@odow
Copy link
Member Author

odow commented Feb 5, 2024

Yeah we could add https://github.com/JuliaRegistries/CompatHelper.jl

I think I avoided it in the past because it tended to be more annoying than useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants