-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve bundling, demo and hover rendering #87
Conversation
|
❌ Deploy Preview for codemirror-json-schema failed.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure changing the module resolution wouldn't reintroduce issues? I see that we are removing the ".je" suffix which was added when fixing a reported issue with resolving the module
b149588
to
45eb768
Compare
@imolorhe great point - I looked up the source to cm6-buildhelper and they also use |
@imolorhe this means disabling top level await, which also means we must instantiate the shiki renderer with an async iife :/ |
forgot changeset for this 😆 |
nodeResolution: bundler
for esm, get rid of .js imports but still something newer thanNode
. keepnodeResolution: Node
for cjs$ref
pointers! (see image)