Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: switch to bundler #109

Closed
wants to merge 1 commit into from
Closed

fix: switch to bundler #109

wants to merge 1 commit into from

Conversation

acao
Copy link
Collaborator

@acao acao commented Jun 1, 2024

experimenting with whether this will fix some of the bundling issues.

moduleResolution: "nodenext" was just not working for our dependencies, and workarounds were not effective for @codemirror/* projects which are bundled with cm-buildhelper which appears to use moduleResolution: 'node'

Copy link

changeset-bot bot commented Jun 1, 2024

⚠️ No Changeset found

Latest commit: f92f2db

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Jun 1, 2024

Deploy Preview for codemirror-json-schema failed.

Name Link
🔨 Latest commit f92f2db
🔍 Latest deploy log https://app.netlify.com/sites/codemirror-json-schema/deploys/665ae91cb4c9d3000866fd59

@acao acao closed this Jun 1, 2024
@acao
Copy link
Collaborator Author

acao commented Jun 1, 2024

#87 already does this and more!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant