Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed the url of apna college under web development file #352

Closed

Conversation

SaileePhal
Copy link
Contributor

IMPORTANT: When creating your Pull Request, please use the following format for the title: Category - Resource Name & Section

PR Title samples:

  • Web development - Tutorials and Course -frontend

Closes Issue

Closes #245

Description:

changed the URL of Apna college under web development file as suggested by sir in
#253

correcting url of apna college

Resource URL:

Apna College: https://www.youtube.com/@ApnaCollegeOfficial

Checklist:

Before submitting your pull request, ensure that you have completed the following tasks:

  • I have carefully reviewed and adhered to the contributing guidelines before creating this pull request.
  • I followed the prescribed PR title template. (Check this if you're adding a resource)

fill the bracket with x. Something like this [x]

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@SaileePhal SaileePhal mentioned this pull request May 20, 2024
2 tasks
@jfmartinz
Copy link
Owner

You moved into the front end development course table, please move it to the Youtube Channels, since you added the URL of the channel not the actual course.

@jfmartinz
Copy link
Owner

The entry you added in the "Front End Development Courses" table is a link to a YouTube channel, not an actual course or playlist. Please move this entry to the "YouTube Channels" table. If you want to add an entry to the "Front End Development Courses" table, ensure it is a link to a specific course or playlist, not just a channel.

@SaileePhal
Copy link
Contributor Author

Ohh okk sir. Sure, will do it , but there is a slight confusion that I have.

Sir ,

  1. The link that I have already added under frontend (merged by you Adding resource under tutorials or courses web dev #326 ) doesn't not need to be changed right?
    Playlist link :
    ---- Apna College: https://youtube.com/playlist?list=PLfqMhTWNBTe3H6c9OGXb5_6wcc1Mca52n&si=UYYv7L3NHDF31bHL
web_dev_link-in frontend
  1. The only changes that I need to do is add additionally a link under of YouTube Channel the below link ? (as suggested by sir in
    Adding resource #253)
    YouTube Channel link:
    --Apna College: https://www.youtube.com/@ApnaCollegeOfficial

Just like the below
correcting url of apna college

Sir can u please confirm the above statements and let me know if I need to do any other changes?

@jfmartinz
Copy link
Owner

  1. Yes
  2. You need to add this under the Youtube Channels section

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💡 [FEATURE] - Adding a resource under web development Readme.md file
2 participants