Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding resource #253

Closed
wants to merge 2 commits into from
Closed

Conversation

SaileePhal
Copy link
Contributor

IMPORTANT: When creating your Pull Request, please use the following format for the title: Category - Resource Name & Section

PR Title samples:

  • Web development - YouTube Channel

Fixes Issue

Closes #245

Description:

Added the resource of Apna College under the YouTube Channel section in Web Development Readme.md File

Resource URL:

Apna College: https://youtube.com/playlist?list=PLfqMhTWNBTe3H6c9OGXb5_6wcc1Mca52n&si=UYYv7L3NHDF31bHL

Checklist:

Before submitting your pull request, ensure that you have completed the following tasks:

  • I have carefully reviewed and adhered to the contributing guidelines before creating this pull request.
  • I followed the prescribed PR title template. (Check this if you're adding a resource)

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@jfmartinz
Copy link
Owner

Is this course about front end, backend or full stack?

@SaileePhal
Copy link
Contributor Author

Front end sir

@jfmartinz
Copy link
Owner

Add it here instead, nad I will merged it after this change, thanks

@SaileePhal
Copy link
Contributor Author

Sure sir. Will do the necessary changes suggested by you.

@jfmartinz
Copy link
Owner

Solve the conflict

@SaileePhal
Copy link
Contributor Author

SaileePhal commented May 19, 2024

Sure sir on it.

@SaileePhal
Copy link
Contributor Author

Done sir via #326

@jfmartinz
Copy link
Owner

Please solve the conflict before I merged this pr, you can refer to this link for more information

@@ -1312,6 +1312,11 @@ to everyone - everywhere!</td>
<td>Youtube channel that teaches Web Development in a super simple way.Explore the content rich channel to become a pro in web development.
</td>
</tr>
<tr>
<td><a href="https://youtube.com/playlist?list=PLfqMhTWNBTe3H6c9OGXb5_6wcc1Mca52n&si=UYYv7L3NHDF31bHL">Apna College</a></td>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<td><a href="https://youtube.com/playlist?list=PLfqMhTWNBTe3H6c9OGXb5_6wcc1Mca52n&si=UYYv7L3NHDF31bHL">Apna College</a></td>
<td><a href="https://www.youtube.com/@ApnaCollegeOfficial">Apna College</a></td>

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another change you need to make was the URL, change it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok sir will do it right a way.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done sir in #352

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💡 [FEATURE] - Adding a resource under web development Readme.md file
2 participants