-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incrementalify #20
Merged
Merged
Incrementalify #20
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
13033f5
Require Jenkins 2.426.3 and latest parent pom
MarkEWaite ad9b7cd
Format with spotless
MarkEWaite 07892be
Incrementalify the plugin
MarkEWaite 4d4aac1
Merge branch 'master' into incrementalify
MarkEWaite 1f43cc5
Remove duplicate entries in maven config
MarkEWaite 50d60fc
Further reduce duplication in pom file
MarkEWaite 48a84db
Add MarkEWaite as a maintainer
MarkEWaite File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| <extensions xmlns="http://maven.apache.org/EXTENSIONS/1.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/EXTENSIONS/1.0.0 http://maven.apache.org/xsd/core-extensions-1.0.0.xsd"> | ||
| <extension> | ||
| <groupId>io.jenkins.tools.incrementals</groupId> | ||
| <artifactId>git-changelist-maven-extension</artifactId> | ||
| <version>1.8</version> | ||
| </extension> | ||
| </extensions> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,2 @@ | ||
| -Pconsume-incrementals | ||
| -Dfindbugs.skip | ||
|
|
||
| -Pmight-produce-incrementals |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,10 +9,10 @@ | |
| </parent> | ||
|
|
||
| <artifactId>label-verifier</artifactId> | ||
| <version>1.5-SNAPSHOT</version> | ||
| <version>${revision}${changelist}</version> | ||
| <packaging>hpi</packaging> | ||
| <name>Jenkins Label Verifier plugin</name> | ||
| <url>https://github.com/jenkinsci/label-verifier-plugin</url> | ||
| <name>Label verifier plugin</name> | ||
| <url>https://github.com/${gitHubRepo}</url> | ||
|
|
||
| <licenses> | ||
| <license> | ||
|
|
@@ -23,27 +23,31 @@ | |
| </licenses> | ||
|
|
||
| <developers> | ||
| <developer> | ||
| <id>kohsuke</id> | ||
| <name>Kohsuke Kawaguchi</name> | ||
| </developer> | ||
| <developer> | ||
| <id>oleg_nenashev</id> | ||
| <name>Oleg Nenashev</name> | ||
| <roles> | ||
| <role>maintainer</role> | ||
| <role>emeritus</role> | ||
| </roles> | ||
| </developer> | ||
| <developer> | ||
| <id>markewaite</id> | ||
| <name>Mark Waite</name> | ||
| <email>[email protected]</email> | ||
| </developer> | ||
| </developers> | ||
|
|
||
| <scm> | ||
| <connection>scm:git:https://github.com/jenkinsci/${project.artifactId}-plugin.git</connection> | ||
| <developerConnection>scm:git:[email protected]:jenkinsci/${project.artifactId}-plugin.git</developerConnection> | ||
| <tag>HEAD</tag> | ||
| <url>https://github.com/jenkinsci/${project.artifactId}-plugin</url> | ||
| <connection>scm:git:https://github.com/${gitHubRepo}.git</connection> | ||
| <developerConnection>scm:git:[email protected]:${gitHubRepo}.git</developerConnection> | ||
| <tag>${scmTag}</tag> | ||
| <url>https://github.com/${gitHubRepo}</url> | ||
| </scm> | ||
|
|
||
| <properties> | ||
| <revision>1.5</revision> | ||
| <changelist>-SNAPSHOT</changelist> | ||
| <gitHubRepo>jenkinsci/${project.artifactId}-plugin</gitHubRepo> | ||
| <jenkins.version>2.426.3</jenkins.version> | ||
| <spotless.check.skip>false</spotless.check.skip> | ||
| </properties> | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the change from title case?
Also https://www.jenkins.io/doc/developer/publishing/style-guides/#name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't aware that title case was a convention. I'll happily adjust that and remove the redundant "plugin" from the end of the name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's documented or required, but it's done fairly consistently. A quick and dirty check indicates that 90+% of plugin titles with 2+ words are title case.