Incrementalify #20
Merged
Incrementalify #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also updates several items in the pom
MarkEWaite
force-pushed
the
incrementalify
branch
from
c9e200a to
07892be
Compare
MarkEWaite
added a commit
to MarkEWaite/repository-permissions-updater
that referenced
this pull request
Jun 29, 2024
I regularly use the label verifier plugin in my installation to assure that I've correctly labeled agents with the command line git version that they are running. It helps me run targeted tests on specific versions of command line git. Pull requests to be merged include: * jenkinsci/label-verifier-plugin#18 * jenkinsci/label-verifier-plugin#19 * jenkinsci/label-verifier-plugin#20 * jenkinsci/label-verifier-plugin#21 * jenkinsci/label-verifier-plugin#22 * jenkinsci/label-verifier-plugin#23 https://plugins.jenkins.io/label-verifier/ shows that the plugin is up for adoption.
MarkEWaite
added
the
chore
daniel-beck
reviewed
Oct 13, 2024
| <packaging>hpi</packaging> | ||
| <name>Jenkins Label Verifier plugin</name> | ||
| <url>https://github.com/jenkinsci/label-verifier-plugin</url> | ||
| <name>Label verifier plugin</name> |
There was a problem hiding this comment.
Why the change from title case?
Also https://www.jenkins.io/doc/developer/publishing/style-guides/#name
There was a problem hiding this comment.
I wasn't aware that title case was a convention. I'll happily adjust that and remove the redundant "plugin" from the end of the name.
There was a problem hiding this comment.
There was a problem hiding this comment.
I wasn't aware that title case was a convention
I don't think it's documented or required, but it's done fairly consistently. A quick and dirty check indicates that 90+% of plugin titles with 2+ words are title case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incremtnality
Allow incrementals for testing
Testing done
Automated tests pass
Submitter checklist