Make (un)present button width dynamic #105
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The present and unpresent button width is fixed to 5.8em. This is problematic as the content might need more space. By removing the width attribute, the element takes the width it requires.
|
The point here is that we want the Enable and Disable buttons to have the same width, so that the interface doesn't move around when the user toggles. |
|
What could maybe be done is to always display "Enable" and "Disable" and then set the opacity. Doing this the button will always take the width of the longest word. |
jech
force-pushed
the
master
branch
2 times, most recently
from
65fa0be to
03038ea
Compare
jech
force-pushed
the
master
branch
2 times, most recently
from
b7172df to
8de77fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The present and unpresent button width is fixed to 5.8em. This is problematic as the content might need more space. By removing the width attribute, the element takes the width it requires.
Screenshot before the modification: "Disable" is overflowing to the right the button.