Fix file transfer error handling.

jech · Mar 22, 2022 · 14bea47 · 14bea47
1 parent 8aaa6d1
commit 14bea47
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/static/galene.js b/static/galene.js
@@ -2369,6 +2369,11 @@ TransferredFile.get = function(up, userid, fileid) {
 };
 
 TransferredFile.prototype.close = function() {
+    if(this.dc) {
+        this.dc.onclose = null;
+        this.dc.onerror = null;
+        this.dc.onmessage = null;
+    }
     if(this.pc)
         this.pc.close();
     this.dc = null;
@@ -2689,12 +2694,14 @@ async function sendFileData(f) {
     async function write(a) {
         while(f.dc.bufferedAmount > f.dc.bufferedAmountLowThreshold) {
             await new Promise((resolve, reject) => {
-                if(f.dc == null) {
+                if(!f.dc) {
                     reject(new Error('File is closed.'));
+                    return;
                 }
                 f.dc.onbufferedamountlow = function(e) {
-                    if(f.dc == null) {
+                    if(!f.dc) {
                         reject(new Error('File is closed.'));
+                        return;
                     }
                     f.dc.onbufferedamountlow = null;
                     resolve();
@@ -2805,7 +2812,7 @@ async function doneReceiveFileData(f) {
  * @param {TransferredFile} f
  */
 function closeReceiveFileData(f) {
-    if(f.datalen != f.size) {
+    if(f.datalen !== f.size) {
         setFileStatus(f, 'Failed.', true, true)
         f.close();
     }