Remove redundant address conversion methods #2151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thoralf-M
force-pushed
the
address-converters-cleanup
branch
from
cfb3f4e
to
b268e6d
Compare
Thoralf-M
force-pushed
the
address-converters-cleanup
branch
from
4013788
to
af13b14
Compare
3 tasks
thibault-martinez
previously approved these changes
Mar 7, 2024
thibault-martinez
approved these changes
Mar 7, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Remove Bech32ToHex, HexToBech32, AccountIdToBech32, AnchorIdToBech32, NftIdToBech32 as this can all be done using AddressToBech32 and ParseBech32Address
Links to any relevant issues
Closes #2079
Type of change
How the change has been tested
Running tests