Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove specific bech32 bindings converters in favour of AddressToBech32 #2079

Closed
3 tasks
thibault-martinez opened this issue Feb 27, 2024 · 3 comments · Fixed by #2151
Closed
3 tasks

Remove specific bech32 bindings converters in favour of AddressToBech32 #2079

thibault-martinez opened this issue Feb 27, 2024 · 3 comments · Fixed by #2151
Assignees
@Thoralf-M
Labels
b-all Bindings - All t-cleanup Task - Cleanup
Milestone
v2.0.0 (Q1 2024)

Comments

@thibault-martinez
Copy link
Member

  • AccountIdToBech32
  • AnchorIdToBech32
  • NftIdToBech32

More?
@github-project-automation github-project-automation bot moved this to Product Backlog in iota-sdk Feb 27, 2024
@thibault-martinez thibault-martinez added this to the v2.0.0 (Q1 2024) milestone Feb 27, 2024
@Thoralf-M
Copy link
Member

  • HexToBech32

@Thoralf-M
Copy link
Member

Should we also remove Bech32ToHex? More error prone than using ParseBech32Address

@Thoralf-M Thoralf-M mentioned this issue Feb 27, 2024
Closed
@thibault-martinez thibault-martinez added b-all Bindings - All t-cleanup Task - Cleanup labels Mar 4, 2024
@thibault-martinez thibault-martinez moved this from Product Backlog to Sprint Backlog in iota-sdk Mar 4, 2024
@Thoralf-M Thoralf-M moved this from Sprint Backlog to In Progress in iota-sdk Mar 6, 2024
@Thoralf-M Thoralf-M mentioned this issue Mar 6, 2024
Merged
@Thoralf-M Thoralf-M linked a pull request Mar 7, 2024 that will close this issue
Remove redundant address conversion methods #2151
Merged
@Thoralf-M Thoralf-M moved this from In Progress to In Review in iota-sdk Mar 7, 2024
@thibault-martinez
Copy link
Member Author

Closed by #2151

@github-project-automation github-project-automation bot moved this from In Review to Done in iota-sdk Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Thoralf-M Thoralf-M

Labels
b-all Bindings - All t-cleanup Task - Cleanup
Projects
iota-sdk
Status: Done
Milestone
v2.0.0 (Q1 2024)
Development

Successfully merging a pull request may close this issue.

Remove redundant address conversion methods Thoralf-M/iota-sdk
2 participants
@thibault-martinez @Thoralf-M