Use default class property for @optional injected properties #1467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haaijman-imagem
force-pushed
the
patch-1
branch
4 times, most recently
from
a131d35
to
361c7a3
Compare
Currently the @optional tag overrides class properties defined with typescript-style default values: ```typescript @Injectable() class Ninja { @Inject(Weapon) @optional() weapon: Weapon = new Katana(); .... } ``` this currently sets the weapon property to `undefined` if no Weapon is present in the container. My proposed change allows does not override the default and results in the weapon property being set to new Katana(). (Default values in the constructor already work, but I would prefer not to add boilerplate constructors if this solution is possible.)
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #1467 +/- ##
==========================================
+ Coverage 99.56% 99.61% +0.05%
==========================================
Files 53 53
Lines 1364 1568 +204
Branches 196 206 +10
==========================================
+ Hits 1358 1562 +204
Partials 6 6
... and 22 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
LGTM. |
Any updates on this? |
|
@haaijman-imagem can you update the branch? After that I would say we can merge it |
Jameskmonger
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the @optional tag overrides class properties defined with typescript-style default values:
this currently sets the weapon property to
undefinedif no Weapon is present in the container. My proposed change allows does not override the default and results in the weapon property being set to new Katana().(Default values in the constructor already work, but I would prefer not to add boilerplate constructors if this solution is possible.)
Related Issue
@optional property injection overrides default
Motivation and Context
How Has This Been Tested?
By copying the test case for optional constructor injection but moving the injection to property injection and then running npm test
Types of changes
Checklist: