You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@optional has become much less for property injection useful because of this bug. I know property injection is not the best kind of injection pattern but it seems like an easy fix.
The text was updated successfully, but these errors were encountered:
Currently the @optional tag overrides class properties defined with typescript-style default values:
this currently sets the weapon property to
undefined
if no Weapon is present in the container.Expected Behavior
injection does not override the default and results in the weapon property being set to new Katana().
Current Behavior
injection overrides the default property to
undefined
instead.Possible Solution
see PR #1467
Steps to Reproduce (for bugs)
Context
@optional has become much less for property injection useful because of this bug. I know property injection is not the best kind of injection pattern but it seems like an easy fix.
The text was updated successfully, but these errors were encountered: