Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conda build #2458

Open
wants to merge 119 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
119 commits
Select commit Hold shift + click to select a range
7045d32
Add a test run
leshikus Oct 7, 2024
3cc291d
Add a custom runner
leshikus Oct 7, 2024
f73dbf0
Add a custom runner, r1
leshikus Oct 7, 2024
21e2444
Add a custom runner, r2
leshikus Oct 7, 2024
e128768
Add a custom runner, r3
leshikus Oct 7, 2024
b983d1b
Add a custom runner, r4
leshikus Oct 7, 2024
763e992
Add a custom runner, r5
leshikus Oct 7, 2024
b96a7b8
Add a custom runner, r6
leshikus Oct 7, 2024
1e566e4
Add a custom runner, r7
leshikus Oct 7, 2024
c12fe51
Add conda runner
leshikus Oct 7, 2024
f9b84f1
Add conda runner, r1
leshikus Oct 7, 2024
0ff7ff1
Add conda runner, r
leshikus Oct 7, 2024
4eaac5e
Add conda runner, r2
leshikus Oct 7, 2024
f394e60
Add conda runner, r3
leshikus Oct 7, 2024
c2f4fb1
Add conda runner, r4
leshikus Oct 7, 2024
b5a092c
Add conda runner, r
leshikus Oct 7, 2024
790e4bf
Add conda runner, r
leshikus Oct 7, 2024
f95f102
Add conda runner, r
leshikus Oct 7, 2024
3e8944f
Add conda runner, r
leshikus Oct 7, 2024
5a8d34e
Add conda runner, r
leshikus Oct 7, 2024
388ab7c
Add conda runner, r
leshikus Oct 7, 2024
75c1290
Add conda runner, r
leshikus Oct 7, 2024
bfe878e
Update conda skiplist
leshikus Oct 8, 2024
7e5b3e4
Add nobasekit run
leshikus Oct 8, 2024
4fee3af
Add nobasekit run, t
leshikus Oct 8, 2024
bb33c73
Try ignore error testrun
leshikus Oct 8, 2024
3035a09
Minor changes, trying to debug
leshikus Oct 8, 2024
79c1bdb
Update conda cache id
leshikus Oct 8, 2024
871975d
Trying to workaround a cache
leshikus Oct 8, 2024
d5d634b
Fix undefined var
leshikus Oct 8, 2024
2261b14
Fix undefined var, r1
leshikus Oct 8, 2024
1272474
Try a skiplist
leshikus Oct 8, 2024
403bd46
Update skiplists
leshikus Oct 9, 2024
d0b71e6
Update skiplists, r1
leshikus Oct 9, 2024
6a0b73b
Update skiplists, r2
leshikus Oct 9, 2024
a2a78d7
Add debug for instrumentation tests
leshikus Oct 9, 2024
d9d6b5b
Fix libGPUHello.so location
leshikus Oct 9, 2024
210eda2
Skip e2e
leshikus Oct 9, 2024
1fc39e2
Skip e2e, r1
leshikus Oct 9, 2024
2014db6
Skip e2e, r2
leshikus Oct 9, 2024
47e0d31
Fix sycl, instrumentation skiplist
leshikus Oct 9, 2024
79e569d
Remove some FIXME
leshikus Oct 10, 2024
116c9b3
Merge branch 'main' into lesh/conda-oct
leshikus Oct 10, 2024
077489a
Remove some FIXME, r1
leshikus Oct 10, 2024
41826fb
Merge branch 'lesh/conda-oct' of https://github.com/intel/intel-xpu-b…
leshikus Oct 10, 2024
378e3fa
Update skiplist after rebase
leshikus Oct 10, 2024
7c55448
Add nobasekit debug
leshikus Oct 10, 2024
67b71d8
Place sycl includes differently, r1
leshikus Oct 10, 2024
0f1c18e
Place sycl includes differently, r2
leshikus Oct 10, 2024
177a344
Fix the skiplist
leshikus Oct 11, 2024
068d215
Fix sycl location
leshikus Oct 11, 2024
3895ae4
Fix the skiplist
leshikus Oct 11, 2024
15a01cf
Add no_basekit debug
leshikus Oct 11, 2024
ada7712
Fix a skiplist, r
leshikus Oct 11, 2024
6da4c5e
Fix a skiplist, r2
leshikus Oct 11, 2024
d9c1b05
Merge branch 'main' into lesh/conda-oct
leshikus Oct 11, 2024
5a9a51d
Remove no_basekit changes
leshikus Oct 11, 2024
769cf96
Remove FIXME
leshikus Oct 11, 2024
5a258a2
Change underscore to minus in script names, add +x
leshikus Oct 11, 2024
6a7898d
Change underscore to minus in script names, add +x, r1
leshikus Oct 11, 2024
c76d874
Merge branch 'main' into lesh/conda-oct
leshikus Oct 11, 2024
7bc7c16
Merge branch 'main' into lesh/conda-oct
leshikus Oct 14, 2024
ecf7c69
Split env installation into a separate step
leshikus Oct 14, 2024
38f9b25
Split env installation into a separate step, r1
leshikus Oct 14, 2024
6e7343b
Split env installation into a separate step, r2
leshikus Oct 14, 2024
258afb3
Split env installation into a separate step, r3
leshikus Oct 14, 2024
4c64440
Split env installation into a separate step, r4
leshikus Oct 14, 2024
60e14a9
Split env installation into a separate step, r5
leshikus Oct 14, 2024
19b2c66
Split env installation into a separate step, r6
leshikus Oct 14, 2024
d3986c2
Update a skiplist after rebase
leshikus Oct 14, 2024
e906657
Remove python version from runner
leshikus Oct 14, 2024
2831322
Merge branch 'main' into lesh/conda-oct
leshikus Oct 14, 2024
4220bf3
Fix transformers install
leshikus Oct 14, 2024
0d6ed87
Fix transformers install, r1
leshikus Oct 14, 2024
ff85043
Fix pytorch install
leshikus Oct 14, 2024
0f94582
Fix pytorch install, r1
leshikus Oct 14, 2024
32e0376
Fix pytorch install, r2
leshikus Oct 14, 2024
5b73c7c
Merge branch 'main' into lesh/conda-oct
leshikus Oct 15, 2024
2a5ca75
Fix transformer dependencies
leshikus Oct 15, 2024
26e4cd5
Merge branch 'lesh/conda-oct' of https://github.com/intel/intel-xpu-b…
leshikus Oct 15, 2024
7ec4963
Merge branch 'main' into lesh/conda-oct
leshikus Oct 15, 2024
804c031
Increase a cache number
leshikus Oct 16, 2024
70549ea
Merge branch 'lesh/conda-oct' of https://github.com/intel/intel-xpu-b…
leshikus Oct 16, 2024
15f2e14
Merge branch 'main' into lesh/conda-oct
leshikus Oct 16, 2024
da86e88
Fix psutil install, r1
leshikus Oct 16, 2024
16c02f4
Merge branch 'lesh/conda-oct' of https://github.com/intel/intel-xpu-b…
leshikus Oct 16, 2024
9d234d1
Fix psutil install, r2
leshikus Oct 16, 2024
1da4d44
Fix pytorch checkout
leshikus Oct 16, 2024
e18bea8
Fix pytorch checkout, r1
leshikus Oct 16, 2024
7298d73
Merge branch 'main' into lesh/conda-oct
leshikus Oct 16, 2024
df03c33
Add a standalone e2e test, r1
leshikus Oct 17, 2024
43e70d9
Add a standalone e2e test, r2
leshikus Oct 17, 2024
d30d33c
Add a standalone e2e test, r3
leshikus Oct 17, 2024
ae9a9d4
Add a standalone e2e test, r4
leshikus Oct 17, 2024
7858466
Add a standalone e2e test, r5
leshikus Oct 17, 2024
59bdfe0
Add a standalone e2e test, r6
leshikus Oct 17, 2024
5ac822d
Add a standalone e2e test, r7
leshikus Oct 17, 2024
19dc278
Add a standalone e2e test, r8
leshikus Oct 17, 2024
a06d843
Add a standalone e2e test, r9
leshikus Oct 17, 2024
ccc9a73
Fix conda path
leshikus Oct 17, 2024
ebf45ec
Fix pytorch path
leshikus Oct 17, 2024
5719ed9
Revert vim autoformatting
leshikus Oct 17, 2024
052234d
Merge branch 'main' into lesh/conda-oct
leshikus Oct 21, 2024
779272d
Try adding sycl to includes
leshikus Oct 21, 2024
7f06bd6
Try adding sycl to includes, r1
leshikus Oct 21, 2024
80663bc
Try adding sycl to includes, r2
leshikus Oct 21, 2024
3fd7c74
Try adding sycl to includes, r3
leshikus Oct 21, 2024
c3a96ee
Try adding sycl to includes, r4
leshikus Oct 21, 2024
24012e0
Try adding sycl to includes, r5
leshikus Oct 21, 2024
af275af
Try adding sycl to includes, r6
leshikus Oct 21, 2024
87bb3b0
Try adding sycl to includes, r7
leshikus Oct 21, 2024
0ac2bf8
Remove unit tests
leshikus Oct 21, 2024
499f412
Remove unit tests, r1
leshikus Oct 21, 2024
0efbdb9
Remove debug
leshikus Oct 21, 2024
bac9ccd
Merge branch 'main' into lesh/conda-oct
leshikus Oct 24, 2024
370c4f5
Moved to a separate workflow
leshikus Oct 24, 2024
8df3398
Merge branch 'main' into lesh/conda-oct
leshikus Oct 24, 2024
df042a2
Merge branch 'main' into lesh/conda-oct
leshikus Oct 24, 2024
8d42079
Fix conda-test trigger
leshikus Oct 24, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions .github/workflows/build-test-reusable.yml
Original file line number Diff line number Diff line change
Expand Up @@ -168,15 +168,7 @@ jobs:

- name: Run E2E test
run: |
# Set WORKSPACE for inductor_xpu_test.sh to make sure it creates "inductor_log" outside of pytorch cloned directory
export WORKSPACE=$GITHUB_WORKSPACE
cd pytorch
pip install pyyaml pandas scipy numpy psutil pyre_extensions torchrec
# TODO: Find the fastest Hugging Face model
$GITHUB_WORKSPACE/scripts/inductor_xpu_test.sh huggingface float32 inference accuracy xpu 0 static 1 0 AlbertForMaskedLM
# The script above always returns 0, so we need an additional check to see if the accuracy test passed
cat $WORKSPACE/inductor_log/*/*/*.csv
grep AlbertForMaskedLM $WORKSPACE/inductor_log/*/*/*.csv | grep -q ,pass,
${{ env.TRITON_TEST_CMD }} --inductor --skip-pip-install

- name: Save pip cache
if: ${{ steps.pip-cache.outputs.status == 'miss' }}
Expand Down
112 changes: 0 additions & 112 deletions .github/workflows/conda-build-test.yml

This file was deleted.

203 changes: 203 additions & 0 deletions .github/workflows/conda-test-reusable.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,203 @@
name: Build and test reusable workflow
run-name: ${{ inputs.run_name }} - ${{ inputs.python_version }} - ${{ inputs.runner_label || 'default'}}

on:
workflow_call:
inputs:
device:
description: Device
type: string
default: max1100
driver_version:
description: Driver version
type: string
default: rolling
runner_label:
description: Runner label, keep empty for default
type: string
default: ""
pytorch_ref:
description: PyTorch ref, keep empty for default
type: string
default: ""
pytorch_mode:
description: PyTorch mode, source or wheels
type: string
default: "source"
python_version:
description: Python version
type: string
required: true
upload_test_reports:
description: Upload test reports
type: boolean
default: false
ignore_errors:
description: Ignore test errors
type: boolean
default: false
skip_list:
description: Skip list
type: string
default: ""
run_name:
description: Custom run name
type: string
default: Build and test
build_llvm:
description: Build LLVM
type: boolean
default: false
enable_unskip:
description: Ignore pytest.skip
type: boolean
default: false
runner_version:
description: Runner label for version
type: string
default: runner-0.0.19
env_manager:
description: Environment manager
default: conda
type: string

permissions: read-all

env:
TRITON_DISABLE_LINE_INFO: 1
TEST_UNSKIP: ${{ inputs.enable_unskip }}

jobs:
integration-tests:
name: Integration tests
runs-on: ${{ fromJson(inputs.runner_label && format('["{0}"]', inputs.runner_label) || format('["{0}", "{1}", "{2}"]', inputs.device, inputs.driver_version, inputs.runner_version)) }}
defaults:
run:
shell: bash -noprofile --norc -eo pipefail scripts/run-${{ inputs.env_manager }}.sh {0}
steps:
- name: Checkout repository
uses: actions/checkout@v4

- name: Load conda cache
id: conda-cache
uses: ./.github/actions/load
env:
CACHE_NUMBER: 6
with:
path: $HOME/miniforge3/envs/triton
key: conda-${{ inputs.env_manager }}-py${{ matrix.python }}-${{ hashFiles('scripts/triton.yml', 'python/pyproject.toml', 'python/setup.py') }}-${{ env.CACHE_NUMBER }}

- name: Install Manager Environment
shell: bash --noprofile --norc -eo pipefail {0}
run: |
scripts/install-${{ inputs.env_manager }}.sh --python-version ${{ inputs.python_version }}
echo $HOME/miniforge3/bin >>$GITHUB_PATH

- name: Print inputs
run: |
cat <<EOF
${{ toJSON(inputs) }}
EOF

- name: Setup Triton, Torch and Transformers
uses: ./.github/actions/install-wheels
with:
gh_token: ${{ secrets.GITHUB_TOKEN }}
install_cmd: conda run --no-capture-output -n triton pip install
python_version: ${{ inputs.python_version }}

- name: Create test-triton command line
run: |
if [[ -n "${{ inputs.skip_list }}" ]]; then
skiplist="$GITHUB_WORKSPACE/scripts/skiplist/${{ inputs.skip_list }}"
elif [[ -n "${{ inputs.driver_version }}" ]]; then
skiplist="$GITHUB_WORKSPACE/scripts/skiplist/${{ inputs.driver_version }}"
else
skiplist="$GITHUB_WORKSPACE/scripts/skiplist/default"
fi

if [ -d "$skiplist" ]; then
skiplist="--skip-list $skiplist"
else
skiplist=
fi

{
echo SKIPLIST="$skiplist"
echo TRITON_TEST_CMD="bash -v -x scripts/test-triton.sh --warning-reports --skip-pytorch-install --reports-dir $GITHUB_WORKSPACE/reports ${{ inputs.ignore_errors && '--ignore-errors' || '' }} $skiplist"
} | tee -a $GITHUB_ENV

- name: Run core tests
run: |
${{ env.TRITON_TEST_CMD }} --core

- name: Run interpreter tests
run: |
${{ env.TRITON_TEST_CMD }} --interpreter --skip-pip-install

- name: Run Tutorials
run: |
${{ env.TRITON_TEST_CMD }} --tutorial --skip-pip-install

- name: Run inductor test
run: |
${{ env.TRITON_TEST_CMD }} --inductor --skip-pip-install

- name: Save conda cache
if: steps.conda-cache.outputs.status == 'miss'
uses: ./.github/actions/save
with:
path: ${{ steps.conda-cache.outputs.path }}
dest: ${{ steps.conda-cache.outputs.dest }}

- name: Pass rate
run: |
pip install defusedxml
source ./scripts/capture-hw-details.sh
python3 scripts/pass_rate.py --reports reports ${{ env.SKIPLIST }}
python3 scripts/pass_rate.py --reports reports --json ${{ env.SKIPLIST }} > pass_rate.json
python3 scripts/pass_rate.py --reports reports --suite tutorials --json ${{ env.SKIPLIST }} > pass_rate_tutorials.json

- name: Report environment details
run: |
source ./scripts/capture-hw-details.sh --quiet
cat <<EOF | tee .env
TIMESTAMP=$(date '+%Y%m%d%H%M%S')
GITHUB_RUN_ID=$GITHUB_RUN_ID
GITHUB_RUN_NUMBER=$GITHUB_RUN_NUMBER
GITHUB_RUN_ATTEMPT=$GITHUB_RUN_ATTEMPT
PYTHON_VERSION=${{ inputs.python_version }}
PYTORCH_REPO=$PYTORCH_REPO
PYTORCH_COMMIT_ID=$PYTORCH_COMMIT_ID
PYTORCH_VERSION=$PYTORCH_VERSION
TRITON_REPO=$GITHUB_REPOSITORY
LIBIGC1_VERSION=$LIBIGC1_VERSION
LEVEL_ZERO_VERSION=$LEVEL_ZERO_VERSION
GPU_DEVICE=$GPU_DEVICE
AGAMA_VERSION=$AGAMA_VERSION
EOF

- name: Upload pass rate report
# upload reports only for the default branch
if: github.ref_name == 'main'
uses: actions/upload-artifact@v4
with:
name: pass_rate-${{ inputs.python_version }}-${{ inputs.runner_label || inputs.driver_version }}
path: pass_rate*.json

- name: Upload tutorials performance report
uses: actions/upload-artifact@v4
with:
name: tutorials-${{ inputs.python_version }}-${{ inputs.runner_label || inputs.driver_version }}
if-no-files-found: warn
include-hidden-files: true
path: |
reports/*/*.csv
.env

- name: Upload test reports
if: inputs.upload_test_reports
uses: actions/upload-artifact@v4
with:
name: test-reports-${{ inputs.python_version }}-${{ inputs.runner_label || inputs.driver_version }}
path: reports
Loading