Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conda build #2458

Open
wants to merge 119 commits into
base: main
Choose a base branch
from
Open

Fix conda build #2458

wants to merge 119 commits into from

Conversation

leshikus
Copy link
Contributor

@leshikus leshikus commented Oct 10, 2024

No-basekit requires more work

@leshikus
Copy link
Contributor Author

I've tried using pre-built wheels, it does not work (jit compiler cannot find oneapi)

@leshikus
Copy link
Contributor Author

@pbchekin Regarding your last offline comments that reusable action becomes too big with this patch, how do you think it is better to approach the problem?

Should I modify the existing actions instead of installing pre-built wheels?

@pbchekin
Copy link
Contributor

@pbchekin Regarding your last offline comments that reusable action becomes too big with this patch, how do you think it is better to approach the problem?

Should I modify the existing actions instead of installing pre-built wheels?

Roughly 50% of steps in build-test-reusable have a check for env_manager. IMHO, it is too much. At this point it is much cleaner just to create something like conda-build-test-reusable. I would expect some code duplication, but the code will be much simpler.

@leshikus
Copy link
Contributor Author

@pbchekin the separation is completed, please take a look

btw, I wonder why conda workflow starts automatically on this PR - how it is implemented? is it some gh magic in some other workflow?

@pbchekin
Copy link
Contributor

pbchekin commented Oct 24, 2024

It starts because the workflow has

  pull_request:
    branches:
      - main

Copy link
Contributor

@pbchekin pbchekin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the new files in scripts such as run-{base,conda}.sh?

@leshikus
Copy link
Contributor Author

you are correct, we no longer need run-base; we need run-conda, because I have also run-no-basekit in other branch

@leshikus
Copy link
Contributor Author

leshikus commented Oct 24, 2024

It starts because the workflow has

@pbchekin this has to be reverted to the scheduled run, is it correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Fix conda build
3 participants