Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: panic index out of range for invalid series keys #24565

Merged
merged 24 commits into from
Jan 23, 2024

Commits on Jan 10, 2024

  1. Configuration menu
    Copy the full SHA
    69f7e61 View commit details
    Browse the repository at this point in the history
  2. feat: test case scaffolding

    jdockerty committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    eb802aa View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2024

  1. chore: merge branch 'master-1.x' of github.com:influxdata/influxdb in…

    …to fix/tsm-out-of-range-index
    jdockerty committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    bc3bb84 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7c33dd9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    32592d3 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2024

  1. Configuration menu
    Copy the full SHA
    0e5318c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7092d1b View commit details
    Browse the repository at this point in the history
  3. feat: add check to remaining files

    As the Len function is used as part of the parseSeriesKey, this also needs to be accounted for on the nil return from this function as it is used in different contexts
    jdockerty committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    cf5717a View commit details
    Browse the repository at this point in the history
  4. feat: expand test cases

    jdockerty committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    e904943 View commit details
    Browse the repository at this point in the history
  5. chore: go fmt

    jdockerty committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    390a9c6 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    2556e38 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2024

  1. Configuration menu
    Copy the full SHA
    de044d4 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. feat: expand test cases

    jdockerty committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    4680200 View commit details
    Browse the repository at this point in the history
  2. fix: nil series key check

    In both sections for index.go there is a pre-existing length check against the series key which should catch invalid values, perhaps this explains why it hasn't cropped up in the reported panics. For even more safety, we can also skip a nil key because we know that subsequent calls will cause a panic where this key is attempted to be used
    jdockerty committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    0498a9c View commit details
    Browse the repository at this point in the history
  3. fix: remove nil tags check

    A key with no tags is valid, so we should not check for BOTH nil key and tags as a key could be nil, which is invalid, yet still have tags and therefore cause the check to pass which we do not want
    jdockerty committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    362468d View commit details
    Browse the repository at this point in the history
  4. 1 Configuration menu
    Copy the full SHA
    86d8dee View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    24cd179 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    39821d6 View commit details
    Browse the repository at this point in the history
  7. fix: logical error in nilKeyHandler

    Prior to this, the else was always defaulted to at the end of the conditional branch, which causes unexpected behaviour and a failure of a bunch of tests.
    jdockerty committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    74b3f3a View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. fix: return tags keep nil data

    In a recent change to this, we agreed on a simple name == nil check for the actual data. As a follow on to this, I just realised that we don't actually want to nil back the tags, even if they're not checked, because having no tags is a valid input so we can simply return whatever we were passed unchanged.
    jdockerty committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    7807d8b View commit details
    Browse the repository at this point in the history
  2. chore: merge branch 'fix/tsm-out-of-range-index' of github.com:influx…

    …data/influxdb into fix/tsm-out-of-range-index
    jdockerty committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    db50933 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. Configuration menu
    Copy the full SHA
    566e0b0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    43d1ea3 View commit details
    Browse the repository at this point in the history
  3. chore: merge branch 'fix/tsm-out-of-range-index' of github.com:influx…

    …data/influxdb into fix/tsm-out-of-range-index
    jdockerty committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    42759c8 View commit details
    Browse the repository at this point in the history