-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: panic index out of range for invalid series keys #24565
Commits on Jan 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 69f7e61 - Browse repository at this point
Copy the full SHA 69f7e61View commit details -
Configuration menu - View commit details
-
Copy full SHA for eb802aa - Browse repository at this point
Copy the full SHA eb802aaView commit details
Commits on Jan 11, 2024
-
chore: merge branch 'master-1.x' of github.com:influxdata/influxdb in…
…to fix/tsm-out-of-range-index
Configuration menu - View commit details
-
Copy full SHA for bc3bb84 - Browse repository at this point
Copy the full SHA bc3bb84View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c33dd9 - Browse repository at this point
Copy the full SHA 7c33dd9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 32592d3 - Browse repository at this point
Copy the full SHA 32592d3View commit details
Commits on Jan 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0e5318c - Browse repository at this point
Copy the full SHA 0e5318cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7092d1b - Browse repository at this point
Copy the full SHA 7092d1bView commit details -
feat: add check to remaining files
As the Len function is used as part of the parseSeriesKey, this also needs to be accounted for on the nil return from this function as it is used in different contexts
Configuration menu - View commit details
-
Copy full SHA for cf5717a - Browse repository at this point
Copy the full SHA cf5717aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e904943 - Browse repository at this point
Copy the full SHA e904943View commit details -
Configuration menu - View commit details
-
Copy full SHA for 390a9c6 - Browse repository at this point
Copy the full SHA 390a9c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2556e38 - Browse repository at this point
Copy the full SHA 2556e38View commit details
Commits on Jan 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for de044d4 - Browse repository at this point
Copy the full SHA de044d4View commit details
Commits on Jan 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4680200 - Browse repository at this point
Copy the full SHA 4680200View commit details -
In both sections for index.go there is a pre-existing length check against the series key which should catch invalid values, perhaps this explains why it hasn't cropped up in the reported panics. For even more safety, we can also skip a nil key because we know that subsequent calls will cause a panic where this key is attempted to be used
Configuration menu - View commit details
-
Copy full SHA for 0498a9c - Browse repository at this point
Copy the full SHA 0498a9cView commit details -
A key with no tags is valid, so we should not check for BOTH nil key and tags as a key could be nil, which is invalid, yet still have tags and therefore cause the check to pass which we do not want
Configuration menu - View commit details
-
Copy full SHA for 362468d - Browse repository at this point
Copy the full SHA 362468dView commit details -
1
Configuration menu - View commit details
-
Copy full SHA for 86d8dee - Browse repository at this point
Copy the full SHA 86d8deeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 24cd179 - Browse repository at this point
Copy the full SHA 24cd179View commit details -
Configuration menu - View commit details
-
Copy full SHA for 39821d6 - Browse repository at this point
Copy the full SHA 39821d6View commit details -
fix: logical error in nilKeyHandler
Prior to this, the else was always defaulted to at the end of the conditional branch, which causes unexpected behaviour and a failure of a bunch of tests.
Configuration menu - View commit details
-
Copy full SHA for 74b3f3a - Browse repository at this point
Copy the full SHA 74b3f3aView commit details
Commits on Jan 19, 2024
-
fix: return tags keep nil data
In a recent change to this, we agreed on a simple name == nil check for the actual data. As a follow on to this, I just realised that we don't actually want to nil back the tags, even if they're not checked, because having no tags is a valid input so we can simply return whatever we were passed unchanged.
Configuration menu - View commit details
-
Copy full SHA for 7807d8b - Browse repository at this point
Copy the full SHA 7807d8bView commit details -
chore: merge branch 'fix/tsm-out-of-range-index' of github.com:influx…
…data/influxdb into fix/tsm-out-of-range-index
Configuration menu - View commit details
-
Copy full SHA for db50933 - Browse repository at this point
Copy the full SHA db50933View commit details
Commits on Jan 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 566e0b0 - Browse repository at this point
Copy the full SHA 566e0b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 43d1ea3 - Browse repository at this point
Copy the full SHA 43d1ea3View commit details -
chore: merge branch 'fix/tsm-out-of-range-index' of github.com:influx…
…data/influxdb into fix/tsm-out-of-range-index
Configuration menu - View commit details
-
Copy full SHA for 42759c8 - Browse repository at this point
Copy the full SHA 42759c8View commit details