feat: extend test cases from feedback

influxdata · Jan 17, 2024 · 86d8dee · davidby-influx · Jan 17, 2024 · 86d8dee
1 parent 362468d
commit 86d8dee
Showing 1 changed file with 15 additions and 0 deletions.
diff --git a/tsdb/series_file_test.go b/tsdb/series_file_test.go
@@ -61,11 +61,26 @@ func TestParseSeriesKey(t *testing.T) {
 			seriesKey:   tsdb.AppendSeriesKey(nil, []byte{}, nil),
 			expectedKey: nil,
 		},
+		{
+			name:        "invalid series key with tags",
+			seriesKey:   tsdb.AppendSeriesKey(nil, []byte{}, models.NewTags(map[string]string{"tag1": "foo"})),
+			expectedKey: nil,
+		},
 		{
 			name:        "valid series key with tags",
 			seriesKey:   tsdb.AppendSeriesKey(nil, []byte("foo"), models.NewTags(map[string]string{"tag1": "foo"})),
 			expectedKey: []byte("foo"),
 		},
+		{
+			name:        "valid series key with empty tags",
+			seriesKey:   tsdb.AppendSeriesKey(nil, []byte("foo"), models.NewTags(map[string]string{})),
+			expectedKey: []byte("foo"),
+		},
+		{
+			name:        "valid series key with nil tags",
+			seriesKey:   tsdb.AppendSeriesKey(nil, []byte("foo"), models.NewTags(nil)),
+			expectedKey: []byte("foo"),
+		},
 		{
 			name:        "valid series key with no tags",
 			seriesKey:   tsdb.AppendSeriesKey(nil, []byte("foo"), nil),