Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore: move hub connector commands to fluvio-hub-util #3611

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - chore: move hub connector commands to fluvio-hub-util #3611

wants to merge 1 commit into from

Conversation

matheus-consoli
Copy link
Contributor

This is the first half of a two-part feature related to #3578.

In this first part, we only move common code from fluvio-cli to fluvio-hub-util behind a feature flag. The second PR will reuse the command definitions in cdk.

@matheus-consoli matheus-consoli mentioned this pull request Oct 20, 2023
Closed
digikata
digikata approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@digikata digikata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we should hold off on merging w/ bors until the tests can pass on the other pr. We're close to kicking off a fluvio release and don't want to be caught between these two PRs.

bors bot pushed a commit that referenced this pull request Nov 1, 2023
@matheus-consoli
feat: add cdk hub command (#3612)
8d473ac 
This is the second PR of a two-part feature related to #3578. The first part can be found in #3611.

Reuse the code from #3611 at `cdk hub`.



CI is expected to fail, see the comment below.

Closes #3578
@matheus-consoli matheus-consoli force-pushed the move-connector-cmd-to-hub-util branch from d3063ce to 534171e Compare November 1, 2023 01:17
@matheus-consoli
Copy link
Contributor Author

bors r+

bors bot pushed a commit that referenced this pull request Nov 1, 2023
@matheus-consoli
chore: move hub connector commands to fluvio-hub-util (#3611)
472e361 
This is the first half of a two-part feature related to #3578.

In this first part, we only move common code from `fluvio-cli` to `fluvio-hub-util` behind a feature flag. The second PR will reuse the command definitions in `cdk`.
@bors bors
Copy link

bors bot commented Nov 1, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore: move hub connector commands to fluvio-hub-util [Merged by Bors] - chore: move hub connector commands to fluvio-hub-util Nov 1, 2023
@bors bors bot closed this Nov 1, 2023
@matheus-consoli matheus-consoli deleted the move-connector-cmd-to-hub-util branch November 1, 2023 03:03
bors bot pushed a commit that referenced this pull request Nov 1, 2023
@matheus-consoli
feat: add cdk hub command (#3612)
6242838 
This is the second PR of a two-part feature related to #3578. The first part can be found in #3611.

Reuse the code from #3611 at `cdk hub`.



CI is expected to fail, see the comment below.

Closes #3578
bors bot pushed a commit that referenced this pull request Nov 1, 2023
@matheus-consoli
feat: add cdk hub command (#3612)
d0dd859 
This is the second PR of a two-part feature related to #3578. The first part can be found in #3611.

Reuse the code from #3611 at `cdk hub`.



CI is expected to fail, see the comment below.

Closes #3578
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digikata digikata digikata approved these changes

@tjtelan tjtelan Awaiting requested review from tjtelan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matheus-consoli @digikata