Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: add cdk hub command #3612

Closed
wants to merge 4 commits into from

Conversation

matheus-consoli
Copy link
Contributor

@matheus-consoli matheus-consoli commented Oct 20, 2023

This is the second PR of a two-part feature related to #3578. The first part can be found in #3611.

Reuse the code from #3611 at cdk hub.

CI is expected to fail, see the comment below.

Closes #3578

Copy link
Contributor

@tjtelan tjtelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty straightforward, LGTM

crates/fluvio-cli/src/client/hub/connector/mod.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@digikata digikata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we just have to resolve the CI issue

Copy link
Contributor

@digikata digikata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matheus-consoli
Copy link
Contributor Author

bors r+

bors bot pushed a commit that referenced this pull request Nov 1, 2023
This is the second PR of a two-part feature related to #3578. The first part can be found in #3611.

Reuse the code from #3611 at `cdk hub`.



CI is expected to fail, see the comment below.

Closes #3578
Copy link

bors bot commented Nov 1, 2023

Build failed:

@matheus-consoli
Copy link
Contributor Author

bors r+

bors bot pushed a commit that referenced this pull request Nov 1, 2023
This is the second PR of a two-part feature related to #3578. The first part can be found in #3611.

Reuse the code from #3611 at `cdk hub`.



CI is expected to fail, see the comment below.

Closes #3578
Copy link

bors bot commented Nov 1, 2023

Build failed:

@EstebanBorai
Copy link
Contributor

bors retry

bors bot pushed a commit that referenced this pull request Nov 1, 2023
This is the second PR of a two-part feature related to #3578. The first part can be found in #3611.

Reuse the code from #3611 at `cdk hub`.



CI is expected to fail, see the comment below.

Closes #3578
Copy link

bors bot commented Nov 1, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: add cdk hub command [Merged by Bors] - feat: add cdk hub command Nov 1, 2023
@bors bors bot closed this Nov 1, 2023
@matheus-consoli matheus-consoli deleted the cdk-hub-cmd branch November 1, 2023 13:22
@matheus-consoli matheus-consoli restored the cdk-hub-cmd branch November 1, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move fluvio hub connector download to ckd hub download
4 participants