Implement non-failing builders for Request, Response and Uri. #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes hyperium#330. Creating a Response with the builder pattern should not require handling errors unless opting in by using a `try_`-method (which returns a `Result<Builder2>`, not a `Builder2` with an interal error state). This is really a breaking change to `response::Builder`, but rather than suggstig a breaking change directly, I introduce an alternative `response::Builder2`. If this is liked, the original `Builder` can be deprecated, and in a later release `Builder2` can be renamed back to `Builder`.
If this change is accpted, the old Builder should be deprecated directly, so the new Builder2 can take its place as soon as semver allows.
Try to make rustc 1.39.0 happy.
Fixes one part of hyperium#330. This makes it possible to create an `Uri` using the builder pattern without hanlding errors. This is really a breaking change to `uri::Builder`, but rather than suggesting a breaking change directly, I introduce an alternative `uri::Builder2`. If this is accepted, the original Builder is deprecated, and in a later release Builder2 can be renamed back to Builder. The new `Builder2` is generic on its contents, which starts out as the empty type `()`. The parts `Scheme`, `Authority` and `PathAndQuery` can be added in any combination, and the `build` method is implemented for valid combinations only.
Fixes one part of hyperium#330. Creating a `Request` with the builder pattern should not require handling errors unless opting in by using a `try_`-method (which returns a `Result<Builder2>`, not a `Builder2` with an internal error state). This is really a breaking change to `request::Builder`, but rather than suggesting a breaking change directly, I introduce an alternative `response::Builder2`. If this is accepted, the original `response::Builder` is deprecated, and in a later release `Builder2` can be renamed back to `Builder`.
This was referenced Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #330. Replaces #442 , #448 , and #454 .
Creating a
Request,Response, orUriwith the builder pattern should not require handling errors unless opting in by using atry_-method (which returns aResult<Builder>, not aBuilderwith an internal error state).This is really a breaking change to the Builders, but rather than suggesting a breaking change directly, I introduce alternatives named
Builder2. If this is accepted, the original Builder is deprecated, and in a later release Builder2 can be renamed back to Builder.The new
uri::Builder2is generic on its contents, which starts out as the empty type(). The partsScheme,AuthorityandPathAndQuerycan be added in any combination, and the build method is implemented for valid combinations only. Looking at the generated documentation foruri::Builder2, it gets a bit repetitive, as the property and a try_property method for each of the three properties is repeated for each of the eight variants of theBuilder2, and a build method for four of them.