Implement a non-failing Response Builder. #442
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaj
force-pushed
the
unfailing-response-builder
branch
from
265e66d to
9e12d91
Compare
Fixes hyperium#330. Creating a Response with the builder pattern should not require handling errors unless opting in by using a `try_`-method (which returns a `Result<Builder2>`, not a `Builder2` with an interal error state). This is really a breaking change to `response::Builder`, but rather than suggstig a breaking change directly, I introduce an alternative `response::Builder2`. If this is liked, the original `Builder` can be deprecated, and in a later release `Builder2` can be renamed back to `Builder`.
If this change is accpted, the old Builder should be deprecated directly, so the new Builder2 can take its place as soon as semver allows.
Try to make rustc 1.39.0 happy.
kaj
force-pushed
the
unfailing-response-builder
branch
from
9e12d91 to
2c6a4de
Compare
|
Replaced by #483 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes one part of #330. Creating a Response with the builder pattern should not require handling errors unless opting in by using a
try_-method (which returns aResult<Builder2>, not aBuilder2with an internal error state).This is really a breaking change to
response::Builder, but rather than suggesting a breaking change directly, I introduce an alternativeresponse::Builder2. If this is accepted, the originalBuilderis deprecated, and in a later releaseBuilder2can be renamed back toBuilder.