Add path_segments to PathAndSegments #276
Conversation
src/uri/path.rs
Outdated
| /// assert_eq!(path_and_query.path_segments().unwrap().collect::<Vec<_>>(), vec!["hello", | ||
| /// "world"]) | ||
| /// ``` | ||
| pub fn path_segments(&self) -> Option<str::Split<char>> { |
There was a problem hiding this comment.
This should probably return a custom iterator: struct PathSegments<str::Split<...>>
Is Option significant in this case or can the iterator be returned directly? Uri::path_and_query already returns an Option.
There was a problem hiding this comment.
You're right, Option in this context is meanless.
There was a problem hiding this comment.
And custom iterator you said, I need help.. I'm so new to rust, When I write any custom iterator, compiler raise lifetime error. T^T
|
All right, First, I reverted unrelated changes. |
And also edited test case from docs
src/uri/path.rs
Outdated
| /// vec!["hello", "world"] | ||
| /// ); | ||
| /// ``` | ||
| pub fn path_segments(&self) -> str::Split<char> { |
There was a problem hiding this comment.
Could you return a new type here? Some type that wraps str::Split<char> and implements Iterator:
struct PathSegments(str::Split<char>);This is for forwards compatibility as it allows us to change the implementation details of the iterator.
I'm also on the fence about whether it should be path_segments or just segments. It is a method on the PathAndQuery type, so it could go either way...
There was a problem hiding this comment.
Sorry to bother you, but I created one. Can you check?
| #[derive(Debug)] | ||
| pub struct PathSegments<'a>(str::Split<'a, char>); | ||
|
|
||
| impl<'a> std::ops::Deref for PathSegments<'a> { |
There was a problem hiding this comment.
Instead of implementing Deref, could you implement, could we implement Iterator<Item = &'a str> and DoubleEndedIterator? The impl would proxy to str::Slice<'a, char>'s implementation.
There was a problem hiding this comment.
I also think that the the CI failure is due to referencing std instead of ::std.
Add path_segments to PathAndSegments and add test_uri_parse_segments to tests.
And I just got noticed rustfmt auto formatted two code files.