feat: support conversions from url::Url
#375
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
application/x-www-form-urlencoded
-based RPC calls. While this encoding is typically handled by the SDKs, this code needs to exist somewhere.TryFrom
conversion fromurl::Url
allows for building complex queries usingurl::Url
's builder methods, but then converting tohttp::Uri
at request construction time.http
's builders implement accept aTryFrom<T>
(inhttp::request::Builder
's case, aUri: TryFrom<T>
), this feature allows for passing aurl::Url
into a request builder.