-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Port HIL-SERL] Fixes for SAC, tested with real robot #619
Draft
helper2424
wants to merge
18
commits into
huggingface:user/michel-aractingi/2024-11-27-port-hil-serl
Choose a base branch
from
helper2424:user/helper2424/fixes_for_sac
base: user/michel-aractingi/2024-11-27-port-hil-serl
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[Port HIL-SERL] Fixes for SAC, tested with real robot #619
helper2424
wants to merge
18
commits into
huggingface:user/michel-aractingi/2024-11-27-port-hil-serl
from
helper2424:user/helper2424/fixes_for_sac
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e implementation, added debug logging info
- Introduced target critic networks in SACPolicy to enhance stability during training. - Updated TD target calculation to incorporate entropy adjustments, improving robustness. - Increased online buffer capacity in configuration from 10,000 to 40,000 for better data handling. - Adjusted learning rates for critic, actor, and temperature to 3e-4 for optimized training performance. These changes aim to refine the SAC implementation, enhancing its robustness and performance during training and inference.
…robot into hil_serl_check_sac
helper2424
changed the base branch from
user/michel-aractingi/2024-11-27-port-hil-serl-backup
to
user/michel-aractingi/2024-11-27-port-hil-serl
January 15, 2025 12:22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
It are fixes based on #616
What this does
Explain what this PR does. Feel free to tag your PR with the appropriate label(s).
Examples:
How it was tested
Explain/show how you tested your changes.
Examples:
test_something
intests/test_stuff.py
.new_feature
and checked that training converges with policy X on dataset/environment Y.some_function
, it now runs X times faster than previously.How to checkout & try? (for the reviewer)
Provide a simple way for the reviewer to try out your changes.
Examples:
SECTION TO REMOVE BEFORE SUBMITTING YOUR PR
Note: Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR. Try to avoid tagging more than 3 people.
Note: Before submitting this PR, please read the contributor guideline.