[FEAT] 매니저가 생성한 리그 전체 조회 #194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldk980130
approved these changes
Aug 15, 2024
| import java.time.LocalDateTime; | ||
| import java.util.List; | ||
|
|
||
| public record LeagueResponseWithInProgressGames( |
There was a problem hiding this comment.
이름이 너무 긴 것도 있는데 너무 구체적인 것 같아. 적당히 세부 사항을 제외하면 어떨까?
진행 중인 게임을 지금을 반환하지만 나중에는 게임이 없을 수도, 모든 게임을 조회할 수도 있으니, 요구 사항이 바뀔 때마다 dto 이름도 수정해야 하면 번거로울 것 같아.
핵심은 리그를 조회하는 거니 리그의 의미만 담아도 좋을 것 같아. 아님 LeagueWithGameResponse라고만 해도 좋을 것 같아
There was a problem hiding this comment.
이 pr 에서 구현한 응답이 LeagueWithGames 여서 분류를 위해 다른 네이밍을 사용했는데.. 자잘자잘하게 차이점들이 있어서 분류해뒀거든. 합쳐도 되려나? 어떻게 생각하는지 궁금해.
src/main/java/com/sports/server/query/repository/GameQueryRepository.java
Outdated
Show resolved
Hide resolved
|
@fingersdanny GameTeam 과 LeagueTeam 양방향 참조하고 있는데 이 부분 수정해서 반영하고 머지할 것! |
hodadako
approved these changes
Aug 18, 2024
[FEAT] 리그에 해당하는 경기 전체 조회
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌍 이슈 번호
📝 구현 내용
🍀 확인해야 할 부분
- 위의 화면에 대한 API 인데 response dto 구조가 괜찮은지 잘 모르겠어요