Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] 게임 등록 기능 구현 #187

Merged
merged 23 commits into from
Aug 21, 2024
Merged

[FEAT] 게임 등록 기능 구현 #187

merged 23 commits into from
Aug 21, 2024

Conversation

Jin409
Copy link
Contributor

@Jin409 Jin409 commented Aug 7, 2024

🌍 이슈 번호

📝 구현 내용

  • 게임 등록

🍀 확인해야 할 부분

스포츠 관련

  • 스포츠를 축구에 한정 짓기로 했기에, Sports 테이블에서 '축구'를 찾아 넣도록 구현했습니다.

테스트 관련

  • 건드려야 할 엔티티가 많아 잘 구현됐는지 확신이 안 서네용.. 서비스 테스트 유심히 한번 봐주세요!

@Jin409 Jin409 self-assigned this Aug 7, 2024
hodadako
hodadako reviewed Aug 10, 2024
View reviewed changes
Copy link
Member

@hodadako hodadako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생했어 코멘트 확인 부탁해~~

src/main/java/com/sports/server/command/game/presentation/GameController.java Show resolved Hide resolved
src/main/java/com/sports/server/command/game/presentation/GameController.java Outdated Show resolved Hide resolved
@Jin409 Jin409 merged commit 82b6b85 into main Aug 21, 2024
1 check passed
@Jin409 Jin409 deleted the feat/#183-game branch August 21, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hodadako hodadako hodadako left review comments

@ldk980130 ldk980130 ldk980130 requested changes

Assignees

@Jin409 Jin409

Labels
feature 🐈 승희
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] 경기 생성 기능 구현
3 participants
@Jin409 @hodadako @ldk980130