Allow inverting switch_as_x cover, lock, valve #19324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emontnemery
commented
Jan 8, 2024
| // Change invert setting | ||
| const origEntityId = this.entry.options?.switch_as_x?.entity_id; | ||
| // remove current helper | ||
| await deleteConfigEntry(this.hass, this.helperConfigEntry.entry_id); |
There was a problem hiding this comment.
The core PR needs an update to allow setting this via an option flow.
Although entity registry has undelete which preserves UUID and entity_id, user configuration such as icon override is not kept.
bramkragten
previously approved these changes
Jan 8, 2024
bramkragten
reviewed
Jan 8, 2024
| if (!origEntityId) { | ||
| // should not happen, guard for types | ||
| } else { | ||
| const configFlow = await createConfigFlow(this.hass, "switch_as_x"); | ||
| const configFlowResult = (await handleConfigFlowStep( | ||
| const configFlow = await createOptionsFlow( |
There was a problem hiding this comment.
Can we do the same for changing the switch as type? (Can be a different PR)
There was a problem hiding this comment.
I would prefer not, because when changing the switch as type we want to delete the entity registry item etc.
bramkragten
reviewed
Jan 8, 2024
| invert: this._switchAsInvert, | ||
| target_domain: this._switchAsDomain, | ||
| } | ||
| )) as DataEntryFlowStepCreateEntry; | ||
| if (configFlowResult.result?.entry_id) { |
There was a problem hiding this comment.
We don't have to do this in this case? As the entity id stays the same there is no need to open a different more info dialog?
bramkragten
reviewed
Jan 9, 2024
src/translations/en.json
Outdated
Comment on lines
1153
to
1155
| "invert_switch_as_cover_description": "Show as open when the switch is off", | ||
| "invert_switch_as_lock_description": "Show as locked when the switch is off", | ||
| "invert_switch_as_valve_description": "[%key:ui::dialogs::entity_registry::editor::invert_switch_as_cover_description%]", |
There was a problem hiding this comment.
Suggested change
| "invert_switch_as_cover_description": "Show as open when the switch is off", | |
| "invert_switch_as_lock_description": "Show as locked when the switch is off", | |
| "invert_switch_as_valve_description": "[%key:ui::dialogs::entity_registry::editor::invert_switch_as_cover_description%]", | |
| "invert" : { | |
| "label": "Invert state", | |
| "descriptions": { | |
| "cover": "Show as open when the switch is off", | |
| "lock": "Show as locked when the switch is off", | |
| "valve": "Show as open when the switch is off", | |
| } | |
| } |
bramkragten
previously approved these changes
Jan 15, 2024
20 tasks
bramkragten
approved these changes
Jan 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Allow inverting switch_as_x cover, lock, valve
Core PR: home-assistant/core#107535
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: