Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add invert option to switch_as_x #107535

Merged
merged 10 commits into from
Jan 24, 2024
Merged

Add invert option to switch_as_x #107535

merged 10 commits into from
Jan 24, 2024

Conversation

emontnemery
Copy link
Contributor

@emontnemery emontnemery commented Jan 8, 2024

Proposed change

Add invert option to switch_as_x cover, lock and valve entities.
When the invert option is enabled, the state of the entity is reversed, as an example an inverted switch_as_x valve will be open when the switch is turned off.

Needs frontend change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Jan 8, 2024

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (switch_as_x) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of switch_as_x can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign switch_as_x Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@emontnemery emontnemery marked this pull request as ready for review January 9, 2024 08:23
Comment on lines 115 to 116
if config_entry.minor_version < 2:
options[CONF_INVERT] = False
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means that if someone has upgraded and configured a switch_as_x with invert=True and then downgrades it will change the option for that entry to invert=False hence changing how that entity works (even if the user then upgrade again).

It should probably only set this option if it's not already there?

homeassistant/components/switch_as_x/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/switch_as_x/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/switch_as_x/cover.py Outdated Show resolved Hide resolved
tests/components/switch_as_x/test_config_flow.py Outdated Show resolved Hide resolved
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft January 22, 2024 09:32
@emontnemery emontnemery marked this pull request as ready for review January 23, 2024 07:21
@frenck frenck added the noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) label Jan 23, 2024
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare
Copy link
Member

MartinHjelmare commented Jan 23, 2024

An approved frontend PR should be linked and the PR description checklist should be filled out. After that we can merge.

@MartinHjelmare MartinHjelmare marked this pull request as draft January 23, 2024 12:37
@MartinHjelmare
Copy link
Member

I found the frontend PR and linked it in the PR description. It's approved but not merged.

@MartinHjelmare
Copy link
Member

Please fill out the PR description and merge.

@emontnemery emontnemery marked this pull request as ready for review January 23, 2024 22:40
@emontnemery emontnemery merged commit 4b2b4ae into dev Jan 24, 2024
23 checks passed
@emontnemery emontnemery deleted the switch_as_x_invert branch January 24, 2024 15:35
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
by-code-owner cla-signed has-tests integration: switch_as_x noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) Quality Scale: internal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Core 2024.1.0 - Valve Domain - Open / Closed are Inverted
4 participants