feat: image search #204
Closed
feat: image search #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
k4lizen
reviewed
Feb 19, 2024
k4lizen
reviewed
Feb 20, 2024
k4lizen
requested changes
Feb 24, 2024
There was a problem hiding this comment.
Since the page url is the one saved in the URL field of Result, this PR currently does not support having two different images come from the same page (since the URL is used as the primary key in the map which collects results). This is a bug. A possible fix is to save the image source url to the URL field, and have an additional field in ImageResult like OriginatingPageURL.
k4lizen
reviewed
Feb 25, 2024
k4lizen
previously approved these changes
Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.