-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: minimize pointers #209
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…versal and switched to using retError channel for requests
aleksasiriski
force-pushed
the
refactor-pointers
branch
from
February 9, 2024 21:34
7645808
to
16c45d7
Compare
aleksasiriski
commented
Feb 9, 2024
aleksasiriski
commented
Mar 3, 2024
k4lizen
requested changes
Mar 7, 2024
…ode for log dumps
k4lizen
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
GJ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idea:
Avoiding to use pointers results in having less garbage collection (most vars are on stack) and makes the code more predictable (if something changes, it must be returned). Of course, not everything should be passed by value and not every pointer is heap allocated so some meaningful situations remain where a pointer is being used (relay, colly, retrievedResult).
Tips:
Changes:
Off topic changes:
go.mod
to require go1.22 and switched for range loops to use_, var
syntax since it doesn't retain the same adress anymore