-
-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CaptureAll #1516
Merged
Merged
CaptureAll #1516
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ea96794
Add tests for a more complete server with capture all branches.
guygastineau cb821c5
Fixed [""] for /route/ on `CaptureAll` apis.
guygastineau 2e5fe27
Fix runRouterEnv for CaptureAllRouter
guygastineau ca86b49
Add changelog for PR #1516 concerning CaptureAll
guygastineau 55ee345
Merge branch 'master' into captureall
domenkozar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
synopsis: Bugfix - CaptureAll produces [""] for empty paths due to trailing slash. | ||
prs: #1516 | ||
issues: #1243 | ||
|
||
description: { | ||
|
||
CaptureAll resulted in `[""]` for empty paths due to trailing slash. Similar | ||
oddities occurred around these edge cases like `"/"` resulted in `[]` correctly, | ||
but `"//"` resulted in `["", ""]`. This patch simply eliminates the first `""` | ||
in the pathinfo list as taken from the wai response. This might break user | ||
code that relies on personal shims to solve the problem, however simply removing their | ||
workarounds should fix their code as the behavior is now sane. | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good thinking