Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CaptureAll #1516

Merged
merged 5 commits into from
Feb 9, 2024
Merged

CaptureAll #1516

merged 5 commits into from
Feb 9, 2024

Commits on Jan 25, 2022

  1. Add tests for a more complete server with capture all branches.

      * This fails two of the tests.  We should probably add a catch all
        at the end that captures anything not matches by the Symbols for
        the preceding branches `arms` and `legs`.
      * When using `CaptureAll` from the root "/" and empty path becomes
        an empty list.  when using it from a branch though an empty path,
        ie. a trailing separator, becomes `mempty` for the type.  Where is
        this happening?  I think this is definitely happening before
        `parseUrlpieces` gets run, so it happens in the machinery for
        Delayed and DelayedIO.  I am still looking for the code that
        produces the `txts` argument for the `captureD` lambda created in
        the `HasServer` instance for `CaptureAll`.
    guygastineau committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    ea96794 View commit details
    Browse the repository at this point in the history
  2. Fixed [""] for /route/ on CaptureAll apis.

      * Routes ending in a `CaptureAll` now get an empty list instead of
        [""] when they have a trailing slash.
      * WARNING: I think this will break the expectation that a rooted
        capture all will produce [""] for `//`.  That is, previously `// =>
        [""]`, but I think `// => []`.  I will make some tests to check
        and see what is going on with this.
    guygastineau committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    cb821c5 View commit details
    Browse the repository at this point in the history
  3. Fix runRouterEnv for CaptureAllRouter

      * Trailing slashes will no longer affect the captures for "rooted"
        CaptureAll apis (test included).
    guygastineau committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    2e5fe27 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2022

  1. Configuration menu
    Copy the full SHA
    ca86b49 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. Configuration menu
    Copy the full SHA
    55ee345 View commit details
    Browse the repository at this point in the history