-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AdvancedTable
: Website documentation
#2628
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
652ffe1
to
9eeb1b9
Compare
313f25a
to
afe2716
Compare
9eeb1b9
to
881bf6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs are looking great! 📝 👍 Just a few small fixes and questions I caught.
website/docs/components/table/advanced-table/partials/code/how-to-use.md
Outdated
Show resolved
Hide resolved
website/docs/components/table/advanced-table/partials/code/how-to-use.md
Show resolved
Hide resolved
website/docs/components/table/advanced-table/partials/code/how-to-use.md
Show resolved
Hide resolved
website/docs/components/table/advanced-table/partials/code/how-to-use.md
Outdated
Show resolved
Hide resolved
website/docs/components/table/advanced-table/partials/code/how-to-use.md
Show resolved
Hide resolved
website/docs/components/table/advanced-table/partials/code/how-to-use.md
Show resolved
Hide resolved
website/docs/components/table/advanced-table/partials/accessibility/accessibility.md
Show resolved
Hide resolved
…ponent-api.md Co-authored-by: Kristin Bradley <[email protected]>
…ility/accessibility.md Co-authored-by: Kristin Bradley <[email protected]>
Co-authored-by: Jory Tindall <[email protected]> Co-authored-by: Lee White <[email protected]> Co-authored-by: Dylan Hyun <[email protected]> Co-authored-by: Heather Larsen <[email protected]> Co-authored-by: Majed <[email protected]> Co-authored-by: LilithJames-HDS <[email protected]>
Co-authored-by: Dylan Hyun <[email protected]>
2997e6d
to
e292b2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one suggestion, overall lgtm 🎉
@@ -481,7 +481,7 @@ To create a column that has right-aligned content, set `@align` to `right` on bo | |||
|
|||
Consuming a large amount of data in a tabular format can lead to an intense cognitive load for the user. As a general principle, care should be taken to simplify the information within a table as much as possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Suggestion] To reduce some of the content here.
Consuming a large amount of data in a tabular format can lead to an intense cognitive load for the user. As a general principle, care should be taken to simplify the information within a table as much as possible. | |
Simplify table content to reduce cognitive load. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a high-level review – seems good!
📌 Summary
If merged, this PR would add documentation for the Advanced Table component to the docs site.
PREVIEW PAGE
🛠️ Detailed description
I currently have the Advanced Table as a subsection of the Table. This can change depending on @hashicorp/hds-design 's final decision.
I also took the applicable examples from the Table docs and adapted them to Advanced Table.
📸 Screenshots
🔗 External links
Jira ticket: HDS-4231
Figma file: [if it applies]
💬 Please consider using conventional comments when reviewing this PR.