Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Dylan Hyun <[email protected]>
  • Loading branch information
shleewhite and dchyun authored Jan 23, 2025
1 parent b4e8875 commit 2997e6d
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ The Advanced Table component itself is where most of the options will be applied
</C.Property>
<C.Property @name="isSelectable" @type="boolean" @default="false">
If set to `true`, creates a “multi-select” table which renders checkboxes in the table header and on the table rows enabling bulk interaction. Use in conjunction with `onSelectionChange` on the `Table` and `selectionKey` on each `Table::Tr`.<br><br>
**Important**: AdvancedTable does **not** support having `isSelectable` true when there are nested rows.
**Important**: Advanced Table does **not** support having `isSelectable` true when there are nested rows.
</C.Property>
<C.Property @name="onSelectionChange" @type="function">
Use in conjunction with `isSelectable` to pass a callback function to know the selection state. Must be used in conjunction with setting a `selectionKey` on each `Table::Tr`.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ It is not currently supported to have `@isStriped`, multi-select, or sortable co

!!!

Similar to the basic AdvancedTable, you can insert your own content into the `:body` block and the component will take care of looping over the `@model` provided for the parent and nested rows. The component adds the expand/collapse button to the `[B].Th` component in each row that has children.
Similar to the basic Advanced Table, you can insert your own content into the `:body` block and the component will take care of looping over the `@model` provided for the parent and nested rows. The component adds the expand/collapse button to the `[B].Th` component in each row that has children.


```handlebars
Expand Down Expand Up @@ -233,7 +233,7 @@ By default, the sort order is set to ascending. To indicate that the column defi

To implement a custom sort callback on a column:

1. add a custom function as the value for `sortingFunction` in the column hash,
1. add a custom function as the value for `sortingFunction` in the column hash.
2. include a custom `onSort` action in your Table invocation to track the sorting order and use it in the custom sorting function.

This is useful for cases where the key might not be A-Z or 0-9 sortable by default, e.g., status, and you’re otherwise unable to influence the shape of the data in the model.
Expand Down Expand Up @@ -298,7 +298,7 @@ customOnSort(_sortBy, sortOrder) {

### Density

To create a condensed or spacious Table, add `@density` to the Table’s invocation. Note that it only affects the Table body, not the Table header.
To create a condensed or spacious Advanced Table, add `@density` to the Advanced Table’s invocation. Note that it only affects the table body, not the table header.

```handlebars
<Hds::AdvancedTable
Expand Down Expand Up @@ -678,7 +678,7 @@ _Notice: only non-sortable headers can be visually hidden._

#### Internationalized column headers, overflow menu dropdown

Here’s an Advanced Table implementation that uses an array hash with localized strings for the column headers, indicates which columns should be sortable, and adds an overflow menu.
Here’s an Advanced Table implementation that uses an array hash with localized strings for the column headers. It indicates which columns should be sortable, and adds an overflow menu.

```handlebars{data-execute=false}
<Hds::AdvancedTable
Expand Down

0 comments on commit 2997e6d

Please sign in to comment.