Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SuperSelect - docs for search position (HDS-4254) #2620

Merged
merged 21 commits into from
Jan 23, 2025
Merged

SuperSelect - docs for search position (HDS-4254) #2620

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
081f9a7
HDS-4254 Update ember-power-select version
KristinLBradley Dec 17, 2024
50080f9
HDS-4254 Add searchFieldPosition to Single and Multiple SuperSelect, …
KristinLBradley Dec 17, 2024
38577bb
HDS-4254 Hard code value of searchFieldPosition to before-options in …
KristinLBradley Dec 19, 2024
b4bc1d8
HDS-4254 Add changeset
KristinLBradley Dec 19, 2024
a14b2d6
Update new-paws-cross.md
KristinLBradley Dec 19, 2024
ea781f6
HDS-4254 Document searchFieldPosition arg
KristinLBradley Dec 19, 2024
efa614b
Apply suggestions from code review
KristinLBradley Dec 19, 2024
20de27e
HDS-4254 Update ember-power-select version
KristinLBradley Dec 17, 2024
d80353f
HDS-4254 Add searchFieldPosition to Single and Multiple SuperSelect, …
KristinLBradley Dec 17, 2024
a4f48b8
HDS-4254 Hard code value of searchFieldPosition to before-options in …
KristinLBradley Dec 19, 2024
bc3d15d
HDS-4254 Add changeset
KristinLBradley Dec 19, 2024
25dad04
Update new-paws-cross.md
KristinLBradley Dec 19, 2024
cbee0c5
Merge branch 'hds-4254-super-select-search-position' of https://githu…
KristinLBradley Jan 6, 2025
ca56cca
Merge branch 'hds-4254-super-select-search-position' into hds-4254-su…
KristinLBradley Jan 6, 2025
58d54e2
HDS-4254 Add version history
KristinLBradley Jan 6, 2025
1d2fcea
Merge branch 'main' into hds-4254-super-select-search-position-docs
KristinLBradley Jan 7, 2025
8eb8340
HDS-4254 Delete API listings for a11y related overrides. Add explanat…
KristinLBradley Jan 7, 2025
0ebe92d
Apply suggestions from code review
KristinLBradley Jan 8, 2025
ea47dc0
removing warning from beforeoptions about the nested interactive as i…
majedelass Jan 13, 2025
4708c43
Merge branch 'main' into hds-4254-super-select-search-position-docs
KristinLBradley Jan 23, 2025
aea2fac
HDS-4254 Undo local changes to yarn.lock
KristinLBradley Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/new-paws-cross.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@hashicorp/design-system-components": minor
---

`SuperSelect` updates including:
- Updated `ember-power-select` from `8.2.0` to `8.6.0`
- Added `searchFieldPosition="before-options"` to fix a11y issue in `Multiple` component
2 changes: 1 addition & 1 deletion packages/components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
"ember-focus-trap": "^1.1.0",
"ember-get-config": "^2.1.1",
"ember-modifier": "^4.1.0",
"ember-power-select": "^8.2.0",
"ember-power-select": "^8.6.0",
"ember-stargate": "^0.4.3",
"ember-style-modifier": "^4.4.0",
"ember-truth-helpers": "^4.0.3",
Expand Down
1 change: 1 addition & 0 deletions packages/components/src/components/hds/form/super-select/multiple/base.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@
@search={{@search}}
@searchEnabled={{@searchEnabled}}
@searchField={{@searchField}}
@searchFieldPosition="before-options"
@searchMessage={{@searchMessage}}
@searchPlaceholder={{this.searchPlaceholder}}
@selected={{@selected}}
Expand Down
1 change: 1 addition & 0 deletions packages/components/src/components/hds/form/super-select/multiple/field.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
@search={{@search}}
@searchEnabled={{@searchEnabled}}
@searchField={{@searchField}}
@searchFieldPosition="before-options"
@searchMessage={{@searchMessage}}
@searchPlaceholder={{@searchPlaceholder}}
@selected={{@selected}}
Expand Down
1 change: 1 addition & 0 deletions packages/components/src/components/hds/form/super-select/single/base.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@
@search={{@search}}
@searchEnabled={{@searchEnabled}}
@searchField={{@searchField}}
@searchFieldPosition="before-options"
@searchMessage={{@searchMessage}}
@searchPlaceholder={{this.searchPlaceholder}}
@selected={{@selected}}
Expand Down
1 change: 1 addition & 0 deletions packages/components/src/components/hds/form/super-select/single/field.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
@search={{@search}}
@searchEnabled={{@searchEnabled}}
@searchField={{@searchField}}
@searchFieldPosition="before-options"
@searchMessage={{@searchMessage}}
@searchPlaceholder={{@searchPlaceholder}}
@selected={{@selected}}
Expand Down
2 changes: 1 addition & 1 deletion showcase/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
"ember-load-initializers": "^2.1.2",
"ember-modifier": "^4.1.0",
"ember-page-title": "^8.2.3",
"ember-power-select": "^8.2.0",
"ember-power-select": "^8.6.0",
"ember-qunit": "^8.1.0",
"ember-resolver": "^11.0.1",
"ember-set-helper": "^3.0.1",
Expand Down
14 changes: 14 additions & 0 deletions website/docs/components/form/super-select/partials/code/component-api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,13 @@ The default values of some [ember-power-select](https://ember-power-select.com/d
<br><br>
<strong>Note</strong>: It cannot be overridden.
</C.Property>
<C.Property @name="searchFieldPosition" @type="string">
Determines whether the search field, when enabled, renders either within the before options content or in the “trigger” area.
<br><br>
Set to `"before-options"` to fix a `PowerSelect` accessibility issue. (Rendering the search input within the trigger area creates a nested interaction.)
KristinLBradley marked this conversation as resolved.
Show resolved Hide resolved
<br><br>
<strong>Note</strong>: It cannot be overridden.
</C.Property>
<C.Property @name="searchPlaceholder" @type="string" @default="Search">
Displays placeholder text in the search input when `@searchEnabled` is set to `true`.
</C.Property>
Expand Down Expand Up @@ -211,6 +218,13 @@ The default values of some [ember-power-select](https://ember-power-select.com/d
<br><br>
Note: It cannot be overridden.
</C.Property>
<C.Property @name="searchFieldPosition" @type="string">
Determines whether the search field, when enabled, renders either within the before options content or in the “trigger” area.
<br><br>
Set to `"before-options"` to fix a `PowerSelect` accessibility issue. (Rendering the search input within the trigger area creates a nested interaction.)
KristinLBradley marked this conversation as resolved.
Show resolved Hide resolved
<br><br>
<strong>Note</strong>: It cannot be overridden.
</C.Property>
<C.Property @name="searchPlaceholder" @type="string" @default="Search">
Displays placeholder text in the search input when `@searchEnabled` is set to `true`.
<br><br>
Expand Down
2 changes: 1 addition & 1 deletion website/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@
"ember-meta": "^2.0.0",
"ember-modifier": "^4.1.0",
"ember-page-title": "^8.2.3",
"ember-power-select": "^8.2.0",
"ember-power-select": "^8.6.0",
"ember-prism": "^0.13.0",
"ember-qunit": "^8.1.0",
"ember-resolver": "^11.0.1",
Expand Down
Loading
Loading