-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SuperSelect
- docs for search position (HDS-4254)
#2620
SuperSelect
- docs for search position (HDS-4254)
#2620
Conversation
…add preliminary Showcase examples
…Multiple SuperSelect, clean up Showcase
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
website/docs/components/form/super-select/partials/code/component-api.md
Outdated
Show resolved
Hide resolved
website/docs/components/form/super-select/partials/code/component-api.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Lee White <[email protected]>
@majedelass Do you think any of the illustrations or design related docs need updating? I didn't see anything obvious when I looked through but wanted to double-check. Web docs preview: https://hds-website-git-hds-4254-super-select-search-p-2680bc-hashicorp.vercel.app/components/form/super-select |
This comment was marked as resolved.
This comment was marked as resolved.
I would think 4.16 |
I went down the rabbit hole with #2612 to better understand where this content was coming from, and I personally found it a bit confusing to read through. Given the context it looks like we're documenting another argument along with the rest of the component API, but the note about it not being possible to override kind of makes this prop useless to consumers. That is, unless we determine that it's useful for consumers to know that we are setting this argument explicitly for accessibility reasons being that it's coming from At a minimum it might be helpful to make that more clear immediately in the component API (leading with the content about not being able to override it and why), then capturing the rest of the details about the property if necessary. Not overly opinionated on the topic and I don't have all of the background, just noting a couple of thoughts. |
…add preliminary Showcase examples
…Multiple SuperSelect, clean up Showcase
…b.com/hashicorp/design-system into hds-4254-super-select-search-position # Conflicts: # yarn.lock
…per-select-search-position-docs
@KristinLBradley personally, I think this is a better solution than including them in the component API list which seemed to create a bit of a false equivalency. Thanks for making this change, curious what other folks think! |
Co-authored-by: Lee White <[email protected]>
…t no longer applies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. I removed the warning within the guidelines about the nested interactive of the previous version.
# Conflicts: # website/docs/components/form/super-select/index.md # yarn.lock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
website changes look good! But why are there changes to yarn.lock?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the new changelog scripts I think these updates can be removed, as they'll be generated later.
aea2fac
📌 Summary
If merged, this PR adds documentation for the
SuperSelect
searchFieldPosition
feature.Related:
SuperSelect
- search position (HDS-4254) #2612🔗 External links
👀 Component checklist
[ ] Percy was checked for any visual regression[ ] A changelog entry was added via Changesets if needed (see templates here)💬 Please consider using conventional comments when reviewing this PR.