fix: added null check for nullable values in formatContractResult() #3210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Logan Nguyen <[email protected]>
quiet-node
requested review from
AlfredoG87,
ebadiere,
lukelee-sl and
a team
as code owners
Signed-off-by: Logan Nguyen <[email protected]>
|
ebadiere
approved these changes
Nov 5, 2024
Nana-EC
approved these changes
Nov 5, 2024
quiet-node
deleted the
3209-formatcontractresult-throws-cannot-read-properties-of-null-reading-substring
branch
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3210 +/- ##
==========================================
- Coverage 83.16% 83.11% -0.05%
==========================================
Files 66 66
Lines 4312 4312
Branches 843 843
==========================================
- Hits 3586 3584 -2
- Misses 483 485 +2
Partials 243 243
Flags with carried forward coverage won't be shown. Click here to find out more. |
quiet-node
added a commit
that referenced
this pull request
Nov 5, 2024
…3210) * fix: added null check for nullable values in formatContractResult() Signed-off-by: Logan Nguyen <[email protected]> * fix: fixed unit tests Signed-off-by: Logan Nguyen <[email protected]> --------- Signed-off-by: Logan Nguyen <[email protected]>
ebadiere
pushed a commit
that referenced
this pull request
Nov 5, 2024
…3210) * fix: added null check for nullable values in formatContractResult() Signed-off-by: Logan Nguyen <[email protected]> * fix: fixed unit tests Signed-off-by: Logan Nguyen <[email protected]> --------- Signed-off-by: Logan Nguyen <[email protected]>
2 tasks
2 tasks
quiet-node
added a commit
that referenced
this pull request
Nov 5, 2024
fix: added null check for nullable values in formatContractResult() (#3210) * fix: added null check for nullable values in formatContractResult() * fix: fixed unit tests --------- Signed-off-by: Logan Nguyen <[email protected]>
quiet-node
added a commit
that referenced
this pull request
Nov 5, 2024
…ontractResult() (#3210)" This reverts commit ca044f1. Signed-off-by: Logan Nguyen <[email protected]>
ebadiere
pushed a commit
that referenced
this pull request
Nov 5, 2024
…ontractResult() (#3210)" (#3216) This reverts commit ca044f1. Signed-off-by: Logan Nguyen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds null checks for nullable values in
formatContractResult()to ensure that, if null values are passed in, they are handled correctly rather than causing aCannot read properties of null (reading...)error.Related issue(s):
Fixes #3209
Notes for reviewer:
Checklist