chore: cherry picked #3120 to release/0.59 #3211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3210) * fix: added null check for nullable values in formatContractResult() Signed-off-by: Logan Nguyen <[email protected]> * fix: fixed unit tests Signed-off-by: Logan Nguyen <[email protected]> --------- Signed-off-by: Logan Nguyen <[email protected]>
quiet-node
requested review from
AlfredoG87,
ebadiere,
lukelee-sl and
a team
as code owners
|
2 tasks
Test Results 21 files - 1 266 suites - 37 38m 18s ⏱️ + 3m 35s For more details on these failures, see this check. Results for commit 119b853. ± Comparison against base commit 22bc051. ♻️ This comment has been updated with latest results. |
ebadiere
approved these changes
Nov 5, 2024
Nana-EC
approved these changes
Nov 5, 2024
quiet-node
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/0.59 #3211 +/- ##
================================================
- Coverage 84.39% 83.11% -1.28%
================================================
Files 69 66 -3
Lines 4473 4312 -161
Branches 881 843 -38
================================================
- Hits 3775 3584 -191
- Misses 431 485 +54
+ Partials 267 243 -24
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Cherry pick #3120
Related issue(s):
Fixes #3209
Notes for reviewer:
Checklist