Fix re-entrancy of non-MPS handshake state machine #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hanno Becker <[email protected]>
hanno-becker
force-pushed
the
non_mps_nbio_fix
branch
from
09d78ec
to
225b9ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The non-MPS handshake state machine is not properly re-entrant upon unavailability of the underlying transport, see #238. This PR aims to fix this, primarily by always making sure to update the state machine prior to calling the potentially-failing handshake-write function. In MPS, this issue does not occur because
mps_dispatch()does never attempt to actually send the message - for exactly the reason to avoid having to make each invocation re-entrant.This PR does not attempt to clean up the state machine beyond getting the tests to pass - this is left for further work.
Fixes #238