Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify TLS 1.3 handshake state machine and handshake handlers #347

Merged
merged 16 commits into from
Aug 8, 2021
Merged

Simplify TLS 1.3 handshake state machine and handshake handlers #347

merged 16 commits into from
Aug 8, 2021

Conversation

hanno-becker
Copy link
Collaborator

@hanno-becker hanno-becker commented Aug 8, 2021 •
edited
Loading

Work in progress. So far:

  • Remove dedicated state for second client hello
  • Remove dedicated state for second server hello
  • Move state machine updates to state handlers
  • Consolidate two CCS sending states
  • Add HS-write wrapper moving the MPS/non-MPS distinction into a few functions, rather than duplicating it in every state handler.

Hanno Becker added 3 commits August 8, 2021 06:23
Hanno Becker added 13 commits August 8, 2021 09:21
Move client-side handshake state update after ticket into handler
6d26c76 
Signed-off-by: Hanno Becker <[email protected]>
Move handshake state updates into handlers
fb22373 
Signed-off-by: Hanno Becker <[email protected]>
Adjust 1.3 client state machine code structure to TLS 1.2
b6997d1 
Signed-off-by: Hanno Becker <[email protected]>
Remove unnecessary flushes from handshake state handlers
b09e5a1 
Signed-off-by: Hanno Becker <[email protected]>
Add handshake msg write wrapper hiding MPS / non-MPS differences
e4ca327 
Signed-off-by: Hanno Becker <[email protected]>
Unify MPS / non-MPS code for outgoing finished and CertReq message
837b3ae 
Signed-off-by: Hanno Becker <[email protected]>
Use MPS/non-MPS wrappers for EndOfEarlyData
fa6ccfc 
Signed-off-by: Hanno Becker <[email protected]>
Use MPS/non-MPS wrapper for ClientHello writing
807221a 
Signed-off-by: Hanno Becker <[email protected]>
Use MPS/non-MPS wrapper for CertificateVerify writing
d235cf4 
Signed-off-by: Hanno Becker <[email protected]>
Use MPS/non-MPS wrapper for Certificate writing
4cbd06e 
Signed-off-by: Hanno Becker <[email protected]>
Use MPS/non-MPS wrapper for NewSessionTicket writer
df23cd2 
Signed-off-by: Hanno Becker <[email protected]>
Use MPS/non-MPS wrapper for HRR writing
f2dc6aa 
Signed-off-by: Hanno Becker <[email protected]>
Use MPS/non-MPS writer for ServerHello writing
f193178 
Signed-off-by: Hanno Becker <[email protected]>
@hanno-becker hanno-becker changed the title Simplify client-side TLS 1.3 handshake state machine Simplify TLS 1.3 handshake state machine and handshake handlers Aug 8, 2021
@hanno-becker hanno-becker changed the base branch from tls13-prototype to tls13-prototype-backup180520 August 8, 2021 13:18
@hanno-becker hanno-becker changed the base branch from tls13-prototype-backup180520 to tls13-prototype August 8, 2021 13:18
@hanno-becker hanno-becker merged commit c95b809 into hannestschofenig:tls13-prototype Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hanno-becker