-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the validity warning message colour to change colour when leased #4404
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works as described 👍👍
Seen on auth, collections, image-loader (merged by @andrew-nowak 7 minutes and 46 seconds ago) Please check your changes! |
Seen on usage, metadata-editor, leases, cropper, media-api (merged by @andrew-nowak 7 minutes and 56 seconds ago) Please check your changes! |
Seen on thrall, kahuna (merged by @andrew-nowak 8 minutes and 4 seconds ago) Please check your changes! |
What does this change?
Fixes a bug in the indicator of what % of selected images have been leased (some problem with interpolating in a "style" attribute during webpack production mode; works fine locally but completely broken in production. Couldn't find the root cause, so switch to using
ng-style
)Then, change the colour of the validity warning message which applies when the image has restrictions or is overquota etc. to teal, so that it is clearer that the warnings have been overridden and the image can be used (usually because a lease has been applied).
How should a reviewer test this change?
Run on TEST, where I have configured getty to (almost certainly) be overquota - check the quotas screen to confirm. Ensure you have edit_metadata permission!
Then, open an overquota image (ie. search
+uploader:getty
). The warning message on the right should be coloured amber, like so:Now add an allow-cropping lease to that image. The message should turn teal (which is the colour used in the search page to indicate "not free, but has been leased and can be used"):
How can success be measured?
Hopefully less confusion about whether a leased image may be used.
Who should look at this?
Tested? Documented?