Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the validity warning message colour to change colour when leased #4404

Merged
merged 4 commits into from
Jan 27, 2025

Conversation

andrew-nowak
Copy link
Member

@andrew-nowak andrew-nowak commented Jan 22, 2025

What does this change?

  1. Fixes a bug in the indicator of what % of selected images have been leased (some problem with interpolating in a "style" attribute during webpack production mode; works fine locally but completely broken in production. Couldn't find the root cause, so switch to using ng-style)

  2. Then, change the colour of the validity warning message which applies when the image has restrictions or is overquota etc. to teal, so that it is clearer that the warnings have been overridden and the image can be used (usually because a lease has been applied).

How should a reviewer test this change?

Run on TEST, where I have configured getty to (almost certainly) be overquota - check the quotas screen to confirm. Ensure you have edit_metadata permission!

Then, open an overquota image (ie. search +uploader:getty). The warning message on the right should be coloured amber, like so:
image

Now add an allow-cropping lease to that image. The message should turn teal (which is the colour used in the search page to indicate "not free, but has been leased and can be used"):

image

How can success be measured?

Hopefully less confusion about whether a leased image may be used.

Who should look at this?

Tested? Documented?

  • locally by committer
  • locally by Guardian reviewer
  • on the Guardian's TEST environment
  • relevant documentation added or amended (if needed)

Copy link

github-actions bot commented Jan 22, 2025

@andrew-nowak andrew-nowak changed the title An/teal overquota leased warning Update the validity warning message colour to change colour when leased Jan 23, 2025
@andrew-nowak andrew-nowak marked this pull request as ready for review January 23, 2025 16:30
@andrew-nowak andrew-nowak requested review from a team as code owners January 23, 2025 16:30
Copy link
Contributor

@bryophyta bryophyta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as described 👍👍

@prout-bot
Copy link

Seen on auth, collections, image-loader (merged by @andrew-nowak 7 minutes and 46 seconds ago) Please check your changes!

@prout-bot
Copy link

Seen on usage, metadata-editor, leases, cropper, media-api (merged by @andrew-nowak 7 minutes and 56 seconds ago) Please check your changes!

@prout-bot
Copy link

Seen on thrall, kahuna (merged by @andrew-nowak 8 minutes and 4 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants