update image flag colour when leased #4413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prout-bot
added
Pending-on-cropper
Pending-on-leases
Pending-on-media-api
Pending-on-image-loader
Pending-on-metadata-editor
Pending-on-collections
Pending-on-usage
Pending-on-kahuna
Pending-on-auth
Pending-on-thrall
Seen-on-usage
Seen-on-kahuna
Seen-on-media-api
and removed
Pending-on-media-api
Pending-on-usage
Pending-on-kahuna
labels
|
Seen on usage, kahuna, media-api (merged by @andrew-nowak 7 minutes and 33 seconds ago) Please check your changes! |
|
Seen on image-loader, metadata-editor, thrall, cropper, collections (merged by @andrew-nowak 7 minutes and 38 seconds ago) Please check your changes! |
|
Seen on leases (merged by @andrew-nowak 7 minutes and 49 seconds ago) Please check your changes! |
1 similar comment
|
Seen on leases (merged by @andrew-nowak 7 minutes and 49 seconds ago) Please check your changes! |
|
Seen on auth (merged by @andrew-nowak 8 minutes and 37 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Follow on from #4404 - update the image's flag immediately when it's been leased. This was an oversight when the colouring was first added - we set it when the image is loaded, but don't reset when it's been updated. We now correct this mistake.
How should a reviewer test this change?
Deploy to TEST. From the search page, select an image (without entering it - use the tickbox and open up the info panel on the right). Set it to some usage rights such as social media, so the image is restricted but not blocked. Add a lease. Does the image's flag turn the leased teal colour, without having to reload the page?
How can success be measured?
Who should look at this?
Tested? Documented?