Add discussion service and associated types #111
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cemms1
changed the title
ioannakok
force-pushed
the
mob/implement-discussion
branch
from
cb21798 to
fc1b0cf
Compare
Co-authored-by: Charlotte Emms <[email protected]> Co-authored-by: George B <[email protected]> Co-authored-by: Jamie B <[email protected]>
ioannakok
force-pushed
the
mob/implement-discussion
branch
from
fc1b0cf to
bb0d332
Compare
|
mxdvl
reviewed
Feb 21, 2024
Comment on lines
+132
to
+137
| struct DiscussionApiResponse { | ||
| 1: required string status; | ||
| 2: required i32 statusCode; | ||
| 3: required string message; | ||
| 4: optional string errorCode; | ||
| } |
There was a problem hiding this comment.
Not sure if errorCode can be absent if status is 'error' or present if status is 'ok'. Maybe a union type similar to what we do in DCR would be more appropriate?
This was referenced Mar 8, 2024
georgeblahblah
added a commit
that referenced
this pull request
Mar 25, 2024
The previous stub was unused. This adds relevant types and signatures for the `recommend` method. This PR is based off commits in #111. This change adds `recommend` by itself so that it can be implemented soon by Android and iOS. We can release the remaining Discussion methods in another Bridget version, so the platforms can implement them when ready. This will enable us to render more articles with discussion using DCAR, more quickly. Co-authored-by: Jamie B <[email protected]> Co-authored-by: Ioanna Kokkini <[email protected]> Co-authored-by: Charlotte <[email protected]>
georgeblahblah
added a commit
that referenced
this pull request
Mar 26, 2024
* Replace Discussion stubs with new recommend signature + types The previous stub was unused. This adds relevant types and signatures for the `recommend` method. This PR is based off commits in #111. This change adds `recommend` by itself so that it can be implemented soon by Android and iOS. We can release the remaining Discussion methods in another Bridget version, so the platforms can implement them when ready. This will enable us to render more articles with discussion using DCAR, more quickly. Co-authored-by: Jamie B <[email protected]> Co-authored-by: Ioanna Kokkini <[email protected]> Co-authored-by: Charlotte <[email protected]>
|
Superceded by #154 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds thrift definitions for the
Discussionservice needed to allow the web view to communicate with the discussion API via native layer of the apps. These tend to be authenticated methods as the unauthenticated ones can be done via the web view alone.