Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Bridget API for discussion #10544

Closed
8 tasks done
Tracked by #9869
ioannakok opened this issue Feb 12, 2024 · 4 comments
Closed
8 tasks done
Tracked by #9869

Create Bridget API for discussion #10544

ioannakok opened this issue Feb 12, 2024 · 4 comments

Comments

@ioannakok
Copy link
Contributor

ioannakok commented Feb 12, 2024

  1. Flesh out the methods:
    const onComment = async (): Promise<CommentResponse> => {
    console.log('onComment');
    return { kind: 'error', error: 'ApiError' };
    };
    const onReply = async (): Promise<CommentResponse> => {
    console.log('onReply');
    return { kind: 'error', error: 'ApiError' };
    };
    const onRecommend = async (): Promise<boolean> => {
    console.log('onRecommend');
    return false;
    };
    const addUsername = async (): Promise<Result<string, true>> => {
    console.log('addUsername');
    return { kind: 'error', error: 'ApiError' };
    };
    const reportAbuse = async (): Promise<Result<string, true>> => {
    console.log('reportAbuse');
    return { kind: 'error', error: 'ApiError' };
    };

Tasks

Preview Give feedback
  1. Discussion
    georgeblahblah
  2. Discussion
    abeddow91 georgeblahblah
    ioannakok mxdvl
  3. Discussion
    ioannakok
  4. Discussion
    abeddow91 ioannakok
  5. Discussion
    georgeblahblah
  6. Discussion
    georgeblahblah
  7. Discussion
    georgeblahblah mxdvl
  8. Discussion
  1. Add the API to bridget
@ioannakok
Copy link
Contributor Author

ioannakok commented Feb 22, 2024

Draft PR for the Bridget API: guardian/bridget#111

@JamieB-gu JamieB-gu linked a pull request Feb 27, 2024 that will close this issue
@cemms1 cemms1 removed their assignment Feb 28, 2024
@ioannakok ioannakok linked a pull request Mar 7, 2024 that will close this issue
@georgeblahblah georgeblahblah moved this from In Progress to This Sprint in WebX Team Mar 8, 2024
@JamieB-gu JamieB-gu moved this from This Sprint to In Progress in WebX Team Mar 12, 2024
@alinaboghiu alinaboghiu assigned mxdvl and abeddow91 and unassigned ioannakok Apr 15, 2024
@alinaboghiu
Copy link
Member

@ioannakok has a draft PR she will add to this ticket

@ioannakok
Copy link
Contributor Author

Draft PR to implement Bridget methods: #10858

@georgeblahblah georgeblahblah moved this from In Progress to Review in WebX Team Apr 15, 2024
@mxdvl
Copy link
Contributor

mxdvl commented Apr 19, 2024

Complete! 🎉

@mxdvl mxdvl closed this as completed Apr 19, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in WebX Team Apr 19, 2024
@mxdvl mxdvl added the Epic label Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment