-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update logs-config.md - structured_metadata #7026
Open
Abuelodelanada
wants to merge
10
commits into
grafana:main
Choose a base branch
from
Abuelodelanada:patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to what I was able to investigate, grafana-agent is not able to forward `structured_metadata` received from `promtail` (or another `grafana-agent` instance) to Loki. https://grafana.slack.com/archives/C01050C3D8F/p1726151855977039
clayton-cornell
approved these changes
Sep 17, 2024
@mattdurham can you do a quick validity check on this one for Agent? |
Co-authored-by: Clayton Cornell <[email protected]>
Co-authored-by: Clayton Cornell <[email protected]>
This was referenced Sep 20, 2024
clayton-cornell
added
the
type/docs
Docs Squad label across all Grafana Labs repos
label
Sep 24, 2024
Looking at the code structured metadata should come through on both json and protobuf. We have a test for it here https://github.com/grafana/agent/blob/8908735a435029f915b7a7bfda1f8b9e7a3d9cd2/internal/component/loki/source/api/internal/lokipush/push_api_server_test.go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to what I was able to investigate, grafana-agent is not able to forward
structured_metadata
received frompromtail
(or anothergrafana-agent
instance) to Loki.https://grafana.slack.com/archives/C01050C3D8F/p1726151855977039
PR Description
Let's imagine we have this scenario:
And Promtail has the following config in which we remove a label (
filename
) to add it asstructured_metadata
:And these logs are received by a grafana-agent with a config like:
filename
is not forwarded to loki asstructured_metadata
.Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist