Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Place filename into structured_metadata #185

Closed
wants to merge 10 commits into from
Closed

Conversation

Abuelodelanada
Copy link
Contributor

@Abuelodelanada Abuelodelanada commented Sep 17, 2024

Issue

This PR takes advantage of structured_metadata in Loki. See: canonical/loki-k8s-operator#445

Solution

This PR removes filename from labels and place it into structured_metadata in order to avoid high cardinality.

Testing Instructions

Run integration tests

@Abuelodelanada Abuelodelanada marked this pull request as ready for review September 18, 2024 15:25
@Abuelodelanada Abuelodelanada requested a review from a team as a code owner September 18, 2024 15:25
@Abuelodelanada
Copy link
Contributor Author

Since we have learn something that was not documented in Grafana docs, which is that grafana-agent is not able to forward structured_metadata coming from promtail (or another grafana-agent) to loki

promtail --> grafana-agent --> loki

We are closing this PR because the pipeline is not reliable. An administrator may wrongly think that because promtail sends structured_metadata it will reach loki when it is not always true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant