impl(internal/genclient/translator/protobuf): simplify protobuf translator #81
+55
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julieqiu
changed the title
julieqiu
changed the title
coryan
approved these changes
Nov 4, 2024
| message.Name = m.GetName() | ||
| message.ID = mFQN | ||
| message.Parent = parent | ||
| func processMessage(state *genclient.APIState, m *descriptorpb.DescriptorProto, mFQN string, parent *genclient.Message) *genclient.Message { |
There was a problem hiding this comment.
I don't claim to know what is idiomatic in Go, but this is basically making the functions methods on the state parameter...
There was a problem hiding this comment.
I wanted to do away with the Translator struct, since it didn't seem to be adding anything and removing made things easier to reason about
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Translator struct isn't necessary, so it is removed to simplify the code in generator/internal/genclient/translator/protobuf