Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl(internal/gclient/translator/protobuf): use a map in normalizeTypes #82

Merged
merged 1 commit into from
Nov 4, 2024
Merged

impl(internal/gclient/translator/protobuf): use a map in normalizeTypes #82

merged 1 commit into from
Nov 4, 2024
+28 −35

Conversation

julieqiu
Copy link
Member

@julieqiu julieqiu commented Nov 4, 2024 •
edited
Loading

Use a map instead of a switch statement for readability.

@julieqiu
impl(internal/gclient/translator/protobuf): use a map in normalizeTypes
072e352 
Use a map instead of a switch statement to make it easier to read.
coryan
coryan approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, in GitHub land it is more common / idiomatic to work out of a fork vs. working out of branches in the main repository.

@julieqiu julieqiu merged commit e1144f0 into main Nov 4, 2024
15 checks passed
@julieqiu julieqiu deleted the julie-pr9 branch November 4, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coryan coryan coryan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julieqiu @coryan