Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bumps swift version to make swiftNIO build possible #12990

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

thomasvl
Copy link
Member

Fixes issue #12882

This is #12883, but on a differently named branch to hopefully get it to pass CI.

Adds a light version of FI that should work on all projects. This will
only be used if the existing FI does not work, e.g. due to failures
around LTO.

Also starts using the CLI version of fuzz-introspector as opposed to
calling `main.py`.

---------

Signed-off-by: David Korczynski <[email protected]>
@TobiasWienand
Copy link

I have renamed my branch to address the issue you have mentioned for my pull request. Hopefully it can be merged :)

@thomasvl
Copy link
Member Author

@jonathanmetzman @DonggeLiu fyi

@thomasvl
Copy link
Member Author

I have renamed my branch to address the issue you have mentioned for my pull request. Hopefully it can be merged :)

Looks like your PR is closed now, you might have to open a new PR to have it reference the new branch.

@TobiasWienand
Copy link

Well in that case let's just keep this PR alive

@jonathanmetzman
Copy link
Contributor

/gcbrun trial_build.py swift

@thomasvl
Copy link
Member Author

Is this safe to be landed?

@thomasvl
Copy link
Member Author

thomasvl commented Feb 4, 2025

@jonathanmetzman can this be merged now?

@jonathanmetzman
Copy link
Contributor

Sorry why is this updating introspector related stuff?

@jonathanmetzman jonathanmetzman merged commit b120842 into google:master Feb 4, 2025
17 of 18 checks passed
@jonathanmetzman
Copy link
Contributor

Ah didn't realize it was a merge issue.

@thomasvl
Copy link
Member Author

thomasvl commented Feb 6, 2025

@jonathanmetzman @DonggeLiu @TobiasWienand - Looks like all the tests passed here, but I'm seeing actually builds failing now that the this is merged - https://oss-fuzz-build-logs.storage.googleapis.com/log-88826beb-a6e3-4720-afd9-6511616586ef.txt Anyone know if other Swift projects are working or not?

@thomasvl thomasvl deleted the swift_5_10 branch February 6, 2025 14:47
@jonathanmetzman
Copy link
Contributor

This is caused by an unrelated coverage/corpus issue.

@thomasvl
Copy link
Member Author

thomasvl commented Feb 6, 2025

This is caused by an unrelated coverage/corpus issue.

Anything I should track for that? I saw an issue opened against SwiftProtobuf about it not building in overage for 3 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants